Handle noEmit(onError) correctly with out(File), fix #416

Author: ivogabe

lib/compiler.ts

@@ -113,7 +113,13 @@ export class ProjectCompiler implements ICompiler {
 
 		result.emitErrors += emitOutput.diagnostics.length;
 		this.reportDiagnostics(emitOutput.diagnostics);
-		
+
+		if (emitOutput.emitSkipped) {
+			result.emitSkipped = true;
+		}
+
+		if (!jsFileName) return;
+
 		let base: string;
 		let baseDeclarations: string;
 		if (file) {
@@ -138,10 +144,6 @@ export class ProjectCompiler implements ICompiler {
 		if (dtsContent !== undefined) {
 			this.project.output.writeDts(baseDeclarations, dtsFileName, dtsContent, file ? file.gulp.cwd : currentDirectory);
 		}
-
-		if (emitOutput.emitSkipped) {
-			result.emitSkipped = true;
-		}
 	}
 
 	private reportDiagnostics(diagnostics: ts.Diagnostic[]) {

test/baselines/noEmit/2.0/errors.txt

@@ -0,0 +1,11 @@
+TypeScript error: test/noEmit/a.ts(1,14): error TS6131: Cannot compile modules using option 'outFile' unless the '--module' flag is 'amd' or 'system'.
+{
+    "transpileErrors": 0,
+    "optionsErrors": 0,
+    "syntaxErrors": 0,
+    "globalErrors": 0,
+    "semanticErrors": 1,
+    "declarationErrors": 0,
+    "emitErrors": 0,
+    "emitSkipped": true
+}

test/baselines/noEmit/dev/errors.txt

@@ -0,0 +1,11 @@
+TypeScript error: test/noEmit/a.ts(1,14): error TS6131: Cannot compile modules using option 'outFile' unless the '--module' flag is 'amd' or 'system'.
+{
+    "transpileErrors": 0,
+    "optionsErrors": 0,
+    "syntaxErrors": 0,
+    "globalErrors": 0,
+    "semanticErrors": 1,
+    "declarationErrors": 0,
+    "emitErrors": 0,
+    "emitSkipped": true
+}

test/noEmit/a.ts

@@ -0,0 +1,3 @@
+export class Hello {
+	value: string;
+}

test/noEmit/gulptask.js

@@ -0,0 +1,7 @@
+var gulp = require('gulp');
+
+module.exports = function(newTS, lib, output, reporter) {
+	return gulp.src('test/noEmit/**/*.ts')
+		.pipe(newTS({ noEmit: true, typescript: lib, outFile: 'foo.js' }, reporter))
+		.pipe(gulp.dest(output));
+}