test: add delay proxy for ping test

Author: amirsalarsafaei

pgxpool/helper_test.go

@@ -0,0 +1,39 @@
+package pgxpool_test
+
+import (
+	"context"
+	"net"
+	"time"
+
+	"github.com/jackc/pgx/v5/pgconn"
+)
+
+// delayProxy is a that introduces a configurable delay on reads from the database connection.
+type delayProxy struct {
+	net.Conn
+	readDelay time.Duration
+}
+
+func newDelayProxy(conn net.Conn, readDelay time.Duration) *delayProxy {
+	p := &delayProxy{
+		Conn:      conn,
+		readDelay: readDelay,
+	}
+
+	return p
+}
+
+func (dp *delayProxy) Read(b []byte) (int, error) {
+	if dp.readDelay > 0 {
+		time.Sleep(dp.readDelay)
+	}
+
+	return dp.Conn.Read(b)
+}
+
+func newDelayProxyDialFunc(readDelay time.Duration) pgconn.DialFunc {
+	return func(ctx context.Context, network, addr string) (net.Conn, error) {
+		conn, err := net.Dial(network, addr)
+		return newDelayProxy(conn, readDelay), err
+	}
+}

pgxpool/pool_test.go

@@ -1291,18 +1291,18 @@ func TestPoolAcquirePingTimeout(t *testing.T) {
 	config, err := pgxpool.ParseConfig(os.Getenv("PGX_TEST_DATABASE"))
 	require.NoError(t, err)
 
-	// Set a very short ping timeout to force timeout during ping and destruction of the connection
-	config.PingTimeout = 1 * time.Nanosecond
+	config.PingTimeout = 200 * time.Millisecond
+	config.ConnConfig.DialFunc = newDelayProxyDialFunc(500 * time.Millisecond)
 
 	var conID *uint32
 	// Only ping the connection with the original PID to force creation of a new connection
 	config.ShouldPing = func(_ context.Context, params pgxpool.ShouldPingParams) bool {
 		if conID != nil && params.Conn.PgConn().PID() == *conID {
 			return true
 		}
-
 		return false
 	}
+
 	// Limit to a single connection to ensure the same connection is reused
 	config.MinConns = 1
 	config.MaxConns = 1