Skip to content

Commit 1bdd28c

Browse files
authored
[demo] Add global image registry (#7620)
## Which problem is this PR solving? - Added global image registry to fix the imageInspectError on running deploy-all.sh in upgarde mode by ci <img width="1327" height="365" alt="image" src="https://github.com/user-attachments/assets/c01ac5dc-7bb2-4935-ab76-7e3e288f4c82" /> ## Description of the changes - ## How was this change tested? - manually running the deploy-all.sh script in both upgrade and clean mode ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: danish9039 <[email protected]>
1 parent 300b511 commit 1bdd28c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

examples/oci/deploy-all.sh

100644100755
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ if [[ "$MODE" == "local" ]]; then
7575
--set allInOne.enabled=true \
7676
--set storage.type=memory \
7777
--set hotrod.enabled=true \
78+
--set global.imageRegistry="" \
7879
--set allInOne.image.repository="localhost:5000/jaegertracing/jaeger" \
7980
--set allInOne.image.tag="${IMAGE_TAG}" \
8081
--set allInOne.image.pullPolicy="Never" \
@@ -90,7 +91,7 @@ else
9091
--set provisionDataStore.cassandra=false \
9192
--set allInOne.enabled=true \
9293
--set storage.type=memory \
93-
--set allInOne.image.repository="docker.io/jaegertracing/jaeger" \
94+
--set allInOne.image.repository="jaegertracing/jaeger" \
9495
--set-file userconfig="./config.yaml" \
9596
--set-file uiconfig="./ui-config.json" \
9697
-f ./jaeger-values.yaml

examples/oci/jaeger-values.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
global:
2+
imageRegistry: docker.io
13
hotrod:
24
enabled: true
35
image:
4-
repository: docker.io/jaegertracing/example-hotrod
6+
repository: jaegertracing/example-hotrod
57
tag: "1.72.0"
68
args:
79
- all

0 commit comments

Comments
 (0)