[refactor]: use slices.Contains to simplify code

Signed-off-by: claudecodering <[email protected]>

Author: claudecodering

internal/storage/elasticsearch/client/index_client.go

@@ -223,11 +223,11 @@ func (i *IndicesClient) IndexExists(index string) (bool, error) {
 }
 
 func (*IndicesClient) aliasesString(aliases []Alias) string {
-	concatAliases := ""
+	var concatAliases strings.Builder
 	for _, alias := range aliases {
-		concatAliases += fmt.Sprintf("[index: %s, alias: %s],", alias.Index, alias.Name)
+		concatAliases.WriteString(fmt.Sprintf("[index: %s, alias: %s],", alias.Index, alias.Name))
 	}
-	return strings.Trim(concatAliases, ",")
+	return strings.Trim(concatAliases.String(), ",")
 }
 
 func (i *IndicesClient) aliasAction(action string, aliases []Alias) error {

internal/storage/integration/es_index_cleaner_test.go

@@ -221,23 +221,23 @@ func createEsIndices(client *elastic.Client, indices []string) error {
 }
 
 func runEsCleaner(days int, envs []string) error {
-	var dockerEnv string
+	var dockerEnv strings.Builder
 	for _, e := range envs {
-		dockerEnv += " -e " + e
+		dockerEnv.WriteString(" -e " + e)
 	}
-	args := fmt.Sprintf("docker run %s --rm --net=host %s %d http://%s", dockerEnv, indexCleanerImage, days, queryHostPort)
+	args := fmt.Sprintf("docker run %s --rm --net=host %s %d http://%s", dockerEnv.String(), indexCleanerImage, days, queryHostPort)
 	cmd := exec.Command("/bin/sh", "-c", args)
 	out, err := cmd.CombinedOutput()
 	fmt.Println(string(out))
 	return err
 }
 
 func runEsRollover(action string, envs []string, adaptiveSampling bool) error {
-	var dockerEnv string
+	var dockerEnv strings.Builder
 	for _, e := range envs {
-		dockerEnv += " -e " + e
+		dockerEnv.WriteString(" -e " + e)
 	}
-	args := fmt.Sprintf("docker run %s --rm --net=host %s %s --adaptive-sampling=%t http://%s", dockerEnv, rolloverImage, action, adaptiveSampling, queryHostPort)
+	args := fmt.Sprintf("docker run %s --rm --net=host %s %s --adaptive-sampling=%t http://%s", dockerEnv.String(), rolloverImage, action, adaptiveSampling, queryHostPort)
 	cmd := exec.Command("/bin/sh", "-c", args)
 	out, err := cmd.CombinedOutput()
 	fmt.Println(string(out))