Speed up ES tests (#7606)

## Which problem is this PR solving?
- Part of #7167

## Description of the changes
- Avoid health check timeouts in tests
- Move bulk processor creation after pings are done

## How was this change tested?
- test

---------

Signed-off-by: Yuri Shkuro <[email protected]>

Author: yurishkuro

internal/storage/elasticsearch/config/config.go

@@ -250,20 +250,6 @@ func NewClient(ctx context.Context, c *Configuration, logger *zap.Logger, metric
 		logger: logger,
 	}
 
-	bulkProc, err := rawClient.BulkProcessor().
-		Before(func(id int64, _ /* requests */ []elastic.BulkableRequest) {
-			bcb.startTimes.Store(id, time.Now())
-		}).
-		After(bcb.invoke).
-		BulkSize(c.BulkProcessing.MaxBytes).
-		Workers(c.BulkProcessing.Workers).
-		BulkActions(c.BulkProcessing.MaxActions).
-		FlushInterval(c.BulkProcessing.FlushInterval).
-		Do(ctx)
-	if err != nil {
-		return nil, err
-	}
-
 	if c.Version == 0 {
 		// Determine ElasticSearch Version
 		pingResult, _, err := rawClient.Ping(c.Servers[0]).Do(ctx)
@@ -302,6 +288,20 @@ func NewClient(ctx context.Context, c *Configuration, logger *zap.Logger, metric
 		}
 	}
 
+	bulkProc, err := rawClient.BulkProcessor().
+		Before(func(id int64, _ /* requests */ []elastic.BulkableRequest) {
+			bcb.startTimes.Store(id, time.Now())
+		}).
+		After(bcb.invoke).
+		BulkSize(c.BulkProcessing.MaxBytes).
+		Workers(c.BulkProcessing.Workers).
+		BulkActions(c.BulkProcessing.MaxActions).
+		FlushInterval(c.BulkProcessing.FlushInterval).
+		Do(ctx)
+	if err != nil {
+		return nil, err
+	}
+
 	return eswrapper.WrapESClient(rawClient, bulkProc, c.Version, rawClientV8), nil
 }
 

internal/storage/v1/elasticsearch/factory_test.go

@@ -318,8 +318,9 @@ func TestESStorageFactoryWithConfig(t *testing.T) {
 func TestESStorageFactoryWithConfigError(t *testing.T) {
 	t.Parallel()
 	cfg := escfg.Configuration{
-		Servers:  []string{"http://127.0.0.1:65535"},
-		LogLevel: "error",
+		Servers:            []string{"http://invalid-host-name:65535"},
+		DisableHealthCheck: true,
+		LogLevel:           "error",
 	}
 	_, err := NewFactoryBase(context.Background(), cfg, metrics.NullFactory, zap.NewNop())
 	require.ErrorContains(t, err, "failed to create Elasticsearch client")

internal/storage/v1/elasticsearch/factoryv1_test.go

@@ -114,15 +114,18 @@ func TestFactoryInitializeErr(t *testing.T) {
 			expectedErr: "Servers: non zero value required",
 		},
 		{
-			name:        "server error",
-			factory:     NewFactory(),
-			expectedErr: "failed to create Elasticsearch client: health check timeout: Head \"http://127.0.0.1:9200\": dial tcp 127.0.0.1:9200: connect: connection refused: no Elasticsearch node available",
+			name: "server error",
+			factory: &Factory{Options: &Options{Config: namespaceConfig{Configuration: escfg.Configuration{
+				Servers:            []string{"http://invalid-host-name:9200"},
+				DisableHealthCheck: true,
+			}}}},
+			expectedErr: "failed to create Elasticsearch client",
 		},
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			err := test.factory.Initialize(metrics.NullFactory, zaptest.NewLogger(t))
-			require.EqualError(t, err, test.expectedErr)
+			require.ErrorContains(t, err, test.expectedErr)
 		})
 	}
 }