Skip to content

Commit 9ce6576

Browse files
committed
Update Factory To Use New Reader Wrapper
Signed-off-by: Mahad Zaryab <[email protected]>
1 parent 424d845 commit 9ce6576

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

storage_v2/factoryadapter/factory.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,9 @@ func (f *Factory) CreateTraceWriter() (tracestore.Writer, error) {
5555

5656
// CreateDependencyReader implements depstore.Factory.
5757
func (f *Factory) CreateDependencyReader() (depstore.Reader, error) {
58-
return f.ss.CreateDependencyReader()
58+
dr, err := f.ss.CreateDependencyReader()
59+
if err != nil {
60+
return nil, err
61+
}
62+
return NewDependencyReader(dr), nil
5963
}

storage_v2/factoryadapter/factory_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ func TestAdapterCreateDependencyReaderError(t *testing.T) {
8787
f1.On("CreateDependencyReader").Return(nil, testErr)
8888

8989
f := NewFactory(f1)
90-
_, err := f.CreateDependencyReader()
90+
r, err := f.CreateDependencyReader()
9191
require.ErrorIs(t, err, testErr)
92+
require.Nil(t, r)
9293
}

0 commit comments

Comments
 (0)