Skip to content
This repository was archived by the owner on Mar 15, 2023. It is now read-only.

Commit f60d12c

Browse files
author
Jacob van Mourik
committed
Fixed version check
1 parent 127b325 commit f60d12c

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/main/java/com/jvms/i18neditor/editor/Editor.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -472,12 +472,10 @@ public void showVersionDialog(boolean newVersionOnly) {
472472
} catch (InterruptedException | ExecutionException | TimeoutException e) {
473473
data = null;
474474
}
475-
if (data != null && !VERSION.equals(data.getTagName())) {
475+
if (data != null && VERSION.compareToIgnoreCase(data.getTagName()) < 0) {
476476
content = MessageBundle.get("dialogs.version.new") + " " +
477477
"<strong>" + data.getTagName() + "</strong><br>" +
478-
"<a href=\"" + data.getHtmlUrl() + "\">" +
479-
MessageBundle.get("dialogs.version.link") +
480-
"</a>";
478+
"<a href=\"" + data.getHtmlUrl() + "\">" + MessageBundle.get("dialogs.version.link") + "</a>";
481479
} else if (!newVersionOnly) {
482480
content = MessageBundle.get("dialogs.version.uptodate");
483481
} else {

src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ private void setupUI() {
219219
helpMenu.setMnemonic(MessageBundle.getMnemonic("menu.help.vk"));
220220

221221
JMenuItem versionMenuItem = new JMenuItem(MessageBundle.get("menu.help.version.title"));
222-
versionMenuItem.addActionListener(e -> editor.showVersionDialog(true));
222+
versionMenuItem.addActionListener(e -> editor.showVersionDialog(false));
223223

224224
JMenuItem aboutMenuItem = new JMenuItem(MessageBundle.get("menu.help.about.title", Editor.TITLE));
225225
aboutMenuItem.addActionListener(e -> editor.showAboutDialog());

0 commit comments

Comments
 (0)