Make it possible to disable test report path validation

[tiago-espinha-img]

What feature do you want to see added?

Currently when adding a Publish JUnit test result report step, this step will validate whether whatever paths are provided under Test report XMLs exist or not.

This causes issues with very large workspaces with millions of files. In particular the issue we've seen was that the Jenkins Agent will attempt to find the specific path e.g., html/report.xml and when it doesn't find it, it'll expand the path to be **/html/report.xml to be able to provide suggestions (e.g., html/report.xml doesn't exist but results/html/report.xml does).

By doing so, the underlying DirectoryScanner that's used to do this will accumulate a VectorSet of String that has all the filepaths of not-matched files.

When a workspace has millions of files, this'll eventually cause the JVM to run out of heap space, the Agent to fall over and with it, bring down all jobs that were running on the Agent.

I'm proposing that by default this validation is disabled (its only purpose seems to make it more user-friendly but serves no practical purpose) and that we maybe expose a checkbox that allows that validation to be optionally enabled.

Thoughts?

Upstream changes

No response

Are you interested in contributing this feature?

Yes, I'd like to contribute to this since this is impacting my work.

[timja]

Seems fine to disable, possibly a validate button could be used instead if it can be made to work.

[tiago-espinha-img]

Seems fine to disable, possibly a validate button could be used instead if it can be made to work.

Hadn't thought of making it a button, but that sounds like a good idea.

I'll give this a try!

[tiago-espinha-img]

@timja I have a working implementation that doesn't validate on input change and instead uses a button:

But thinking more about it, we now effectively have a kill the agent button which doesn't feel great 😃

I think I'd prefer to completely disable the validation on the basis that:

• It's less likely to lead to really bad side effects.
• At configure time, the JUnit test result report is unlikely to exist anyway since we'd expect test results to be created at the end of test runs, so more often than not, that validation should be failing (and leading to the behaviour with globbing the whole workspace to try and find it).

Do you have strong feelings against disabling it altogether and not adding the button?

[tiago-espinha-img]

IMO disabling it altogether presents less risk, so that's the change I've put in this PR: #730

Can I ask for a review please?

[timja]

See #730 (comment)