String.fromInt 2 => "2"

[miniBill]

Same for String.fromFloat <float> and String.toInt "string".

Maybe also for String.toFloat "float" but I'm wary of IEEE here.

[jfmengels]

I agree that String.toFloat may be slightly dangerous, though we could compare it to the original string and see if it's indeed the same. The same it true for integers, which may be really large.

So to summarize in our proposal style, and add a few more:

String.fromInt 2
--> "2" ✅ https://github.com/jfmengels/elm-review-simplify/pull/362

String.fromFloat 2.2
--> "2.2" ✅ https://github.com/jfmengels/elm-review-simplify/pull/362

String.toInt "23"
--> Just 23

String.toInt "23345678987654345678987654345678"
-- no change, does not result in the same output as in the literal

String.toInt "string"
--> Nothing

String.fromChar 'c'
--> "c"

Not sure about this one. What do you think?

String.cons 's' "tr"
--> "str"

[miniBill]

+1 on the String.cons

[jfmengels]

Adding it here from #362:
I'm not sure whether we want this or not:

String.fromInt 0x2
--> "2"