Make phpstan level max

Author: pyrech

Command/GifOptimizerCommand.php

@@ -77,15 +77,30 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $imageDir = $input->getArgument('image_dir');
 
-        if (!is_dir($imageDir)) {
+        if (!\is_string($imageDir) || !is_dir($imageDir)) {
             throw new \RuntimeException($imageDir . ' is not a valid directory');
         }
 
         $pattern = $imageDir . '/*/*.gif';
-        foreach (glob($pattern) as $path) {
+        $images = glob($pattern);
+
+        if (!$images) {
+            throw new \RuntimeException('No images found in ' . $pattern);
+        }
+
+        foreach ($images as $path) {
             $realPath = realpath($path);
+
+            if (!$realPath) {
+                throw new \RuntimeException('Could not find ' . $path);
+            }
+
             $originalFileSize = filesize($realPath);
 
+            if (!$originalFileSize) {
+                throw new \RuntimeException('Could not get file size for ' . $realPath);
+            }
+
             $output->writeln(sprintf('<info>Optimizing image: %s</info>', $realPath));
             $output->writeln(sprintf('<comment>Before: %s</comment>', $this->formatBytes($originalFileSize)));
 
@@ -96,6 +111,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             $optimizedFileSize = filesize($realPath);
 
+            if (!$optimizedFileSize) {
+                throw new \RuntimeException('Could not get file size for ' . $realPath);
+            }
+
             $output->writeln(sprintf('<comment>After: %s</comment>', $this->formatBytes($optimizedFileSize)));
 
             $percentage = 100 - (($optimizedFileSize / $originalFileSize) * 100);

DependencyInjection/GifExceptionExtension.php

@@ -30,13 +30,21 @@ public function load(array $configs, ContainerBuilder $container): void
         $gifs = [];
 
         $pattern = __DIR__ . '/../Resources/public/images/*/*.gif';
-        foreach (glob($pattern) as $path) {
-            $gifs[basename(\dirname($path))][] = basename($path);
+        $images = glob($pattern);
+
+        if ($images) {
+            foreach ($images as $path) {
+                $gifs[basename(\dirname($path))][] = basename($path);
+            }
         }
 
         $pattern = __DIR__ . '/../Resources/public/images/other/*.gif';
-        foreach (glob($pattern) as $path) {
-            $gifs['other'][] = basename($path);
+        $images = glob($pattern);
+
+        if ($images) {
+            foreach ($images as $path) {
+                $gifs['other'][] = basename($path);
+            }
         }
 
         $container->getDefinition('gif_exception.listener.replace_image')->replaceArgument(0, $gifs);

EventListener/ReplaceImageListener.php

@@ -37,6 +37,10 @@ public function onKernelResponse(ResponseEvent $event): void
         }
 
         $exception = $event->getRequest()->attributes->get('exception');
+        if (!($exception instanceof \Throwable)) {
+            return;
+        }
+
         // Status code is not set by the exception controller but only by the
         // kernel at the very end.
         // So lets use the status code from the flatten exception instead.
@@ -51,7 +55,7 @@ public function onKernelResponse(ResponseEvent $event): void
         $gif = $this->getRandomGif($dir);
         $url = $this->getGifUrl($dir, $gif);
 
-        $content = $event->getResponse()->getContent();
+        $content = (string) $event->getResponse()->getContent();
 
         $content = preg_replace(
             '@<div class="exception-illustration hidden-xs-down">(.*?)</div>@ims',
@@ -86,6 +90,10 @@ private function getGifDir(int $statusCode): string
      */
     private function getRandomGif(string $dir): string
     {
+        if (!\array_key_exists($dir, $this->gifs) || 0 === \count($this->gifs[$dir])) {
+            return '';
+        }
+
         $imageIndex = random_int(0, \count($this->gifs[$dir]) - 1);
 
         return $this->gifs[$dir][$imageIndex];

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-	level: 6
+	level: 9
 	paths:
 		- .
 	excludePaths: