Skip to content

Commit c9d1668

Browse files
committed
[power_switching_tools_ros] Fix udev setting script
1 parent 68de225 commit c9d1668

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

power_switching_tools_ros/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ Hubs supporting PPPS (e.g., [VirtualHere USB 3 4-Port Hub](https://modularkvmip.
9090

9191
This is required for running the driver node without `sudo`.
9292
```bash
93-
rosrun power_switching_tools_ros setup_for_usb_ppps_hub
93+
rosrun power_switching_tools_ros setup_udev_for_usb_ppps_hub
9494
# Reboot your PC after this script finishes
9595
# Note that this script adds your user to dialout group, which means "chmod" becomes unnecessary for accessing some device files (e.g., /dev/ttyACM0)
9696
```

power_switching_tools_ros/scripts/setup_for_usb_ppps_hub renamed to power_switching_tools_ros/scripts/setup_udev_for_usb_ppps_hub

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
RULES_PATH="/etc/udev/rules.d/52-usb.rules"
44

55
echo ""
6-
echo "This script sets up your PC to control USB PPPS hubs"
6+
echo "This script sets up udev to control USB PPPS hubs"
77
echo ""
88

99
echo ""
@@ -18,8 +18,11 @@ sudo udevadm control --reload
1818
sudo udevadm trigger
1919

2020
echo ""
21-
echo "Adding your user to dialout group"
21+
echo "Adding your user to dialout group to control the hubs without sudo"
2222
echo ""
2323
sudo usermod -a -G dialout "$USER"
24+
# We cannot make udev rules giving authority to all users for security reasons
25+
# because we cannot limit devices or operations subject to those rules on Linux before 6.0:
26+
# https://github.com/mvp/uhubctl/blob/v2.6.0/udev/rules.d/52-usb.rules#L18-L19
2427

2528
echo "Setup finished. Reboot your PC"

0 commit comments

Comments
 (0)