Skip to content

Conversation

@kt3k
Copy link
Contributor

@kt3k kt3k commented Oct 31, 2025

It looks like the transpiled result of islands/CopyButton.tsx is overwritten by the result of routes/admin/(_islands)/CopyButton.tsx during the build process. This PR tries to fix the issue by renaming the admin version to AdminCopyButton.

The built script assets look like:

BEFORE

AuditURLQuerySearch.js     GitHubUserLink.js          ScopeMemberRole.js         chunk-CS7BFPU5.js
Authorize.js               GlobalSearch.js            TicketMessageInput.js      chunk-EL7WOSTS.js
BreadcrumbsSticky.js       HeaderLogo.js              TicketModal.js             chunk-FD4CNUX4.js
CopyButton.js              HomepageHeroParticles.js   UserMenu.js                chunk-FOUP4XVY.js
CreatePackage.js           LocalSymbolSearch.js       apexcharts.esm-IDJUS2H7.js chunk-JSNILFVT.js
CreateToken.js             OverallStatus.js           chunk-26HBMVF5.js          chunk-RTVFZVGS.js
DarkModeToggle.js          PackageDescriptionEditor.js chunk-2HTBGNW6.js          chunk-TZGWON76.js
DependencyGraph.js         PackageGitHubSettings.js   chunk-3IKIH2UU.js          chunk-VS66CSKJ.js
DevelopmentLogin.js        PublishingTaskRequeue.js   chunk-4UTZPDT3.js          chunk-WOT6VMZA.js
DownloadChart.js           RevokeToken.js             chunk-6UWR3SRP.js          fresh-runtime.js
DownloadWidget.js          ScopeDescriptionForm.js    chunk-B2UJ3RWN.js          metafile.json
EditModal.js               ScopeInviteForm.js         chunk-BGFMN264.js
GitHubActionsLink.js       ScopeMemberLeave.js        chunk-CD3SP5L4.js

AFTER

AdminCopyButton.js         GitHubActionsLink.js       ScopeMemberLeave.js        chunk-CS7BFPU5.js
AuditURLQuerySearch.js     GitHubUserLink.js          ScopeMemberRole.js         chunk-FD4CNUX4.js
Authorize.js               GlobalSearch.js            TicketMessageInput.js      chunk-FOUP4XVY.js
BreadcrumbsSticky.js       HeaderLogo.js              TicketModal.js             chunk-RE76VC7A.js
CopyButton.js              HomepageHeroParticles.js   UserMenu.js                chunk-RTBY5TDF.js
CreatePackage.js           LocalSymbolSearch.js       apexcharts.esm-IDJUS2H7.js chunk-RTVFZVGS.js
CreateToken.js             OverallStatus.js           chunk-26HBMVF5.js          chunk-T65JOWSX.js
DarkModeToggle.js          PackageDescriptionEditor.js chunk-4ECDJ3EW.js          chunk-TZGWON76.js
DependencyGraph.js         PackageGitHubSettings.js   chunk-4UTZPDT3.js          chunk-VS66CSKJ.js
DevelopmentLogin.js        PublishingTaskRequeue.js   chunk-4XSVJRE3.js          chunk-WOT6VMZA.js
DownloadChart.js           RevokeToken.js             chunk-B2UJ3RWN.js          chunk-WZKL7APY.js
DownloadWidget.js          ScopeDescriptionForm.js    chunk-BGFMN264.js          fresh-runtime.js
EditModal.js               ScopeInviteForm.js         chunk-CD3SP5L4.js          metafile.json

In AFTER result, CopyButton.js has completely different contents as BEFORE one (and it seems using props.text correctly instead of props.value

related #1219

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats added this pull request to the merge queue Oct 31, 2025
Merged via the queue into jsr-io:main with commit 5072417 Oct 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants