Remove href-no-hash rule

Author: jessebeach

CHANGELOG.md

@@ -1,7 +1,8 @@
 6.0.0 / 2017-06-05
 =================
 - [new] Add rule `anchor-is-valid`. See documentation for configuration options. Thanks @AlmeroSteyn.
-- [update] The rule `label-has-for` now allows inputs nested in label tags. Previously it was strict about requiring a `for` attribute. Thanks @ignatiusreza. 
+- [breaking] `href-no-hash` replaced with `anchor-is-valid` in the recommended and strict configs. Use the `invalidHref` aspect (active by default) in `anchor-is-valid` to continue to apply the behavior provided by `href-no-hash`.
+- [update] The rule `label-has-for` now allows inputs nested in label tags. Previously it was strict about requiring a `for` attribute. Thanks @ignatiusreza.
 - [update] New configuration for `interactive-supports-focus`. Recommended and strict configs for now contain a trimmed-down whitelist of roles that will be checked.
 - [fix] Incompatibility between node version 4 and 5. Thanks @evilebottnawi.
 - [fix] Missing README entry for `media-has-caption`. Thanks @ismail-syed.
@@ -26,13 +27,13 @@
 ==================
 - [breaking] Refactor `img-has-alt` rule into `alt-text` rule
 - [breaking] Rule `onclick-has-role` is removed. Replaced with `no-static-element-interactions` and `no-noninteractive-element-interactions`.
-- [breaking] Rule `onclick-has-focus` is removed. Replaced with `interactive-supports-focus`. 
+- [breaking] Rule `onclick-has-focus` is removed. Replaced with `interactive-supports-focus`.
 - [new] - Add rule `media-has-caption` rule
 - [new] - Add `ignoreNonDOM` option to `no-autofocus`.
 - [new] - Add rule `no-interactive-element-to-noninteractive-role`
 - [new] - Add rule `no-noninteractive-element-to-interactive-role`
 - [new] - Add rule `no-noninteractive-tabindex`
-- [new] - Configs split into "recommended" and "strict". 
+- [new] - Configs split into "recommended" and "strict".
 - [enhanced] - Configuration options added to `no-static-element-interactions` and `no-noninteractive-element-interactions`. Options allow for fine-tuning of elements and event handlers to check.
 
 

__tests__/src/rules/anchor-is-valid-test.js

@@ -86,6 +86,7 @@ const componentsAndSpecialLinkAndNoHrefAspect = [{
 ruleTester.run('anchor-is-valid', rule, {
   valid: [
     // DEFAULT ELEMENT 'a' TESTS
+    { code: '<Anchor />;' },
     { code: '<a {...props} />' },
     { code: '<a href="foo" />' },
     { code: '<a href={foo} />' },
@@ -250,7 +251,6 @@ ruleTester.run('anchor-is-valid', rule, {
     { code: '<a href="javascript:void(0)" />', options: noHrefPreferButtonAspect },
     { code: '<a href={"javascript:void(0)"} />', options: noHrefPreferButtonAspect },
 
-
     // SHOULD BE BUTTON
     { code: '<a onClick={() => void 0} />', options: invalidHrefAspect },
     { code: '<a href="#" onClick={() => void 0} />', options: noHrefAspect },

__tests__/src/rules/href-no-hash-test.js

@@ -13,7 +13,6 @@ module.exports = {
     'aria-unsupported-elements': require('./rules/aria-unsupported-elements'),
     'click-events-have-key-events': require('./rules/click-events-have-key-events'),
     'heading-has-content': require('./rules/heading-has-content'),
-    'href-no-hash': require('./rules/href-no-hash'),
     'html-has-lang': require('./rules/html-has-lang'),
     'iframe-has-title': require('./rules/iframe-has-title'),
     'img-redundant-alt': require('./rules/img-redundant-alt'),
@@ -48,14 +47,14 @@ module.exports = {
         'jsx-a11y/accessible-emoji': 'error',
         'jsx-a11y/alt-text': 'error',
         'jsx-a11y/anchor-has-content': 'error',
+        'jsx-a11y/anchor-is-valid': 'error',
         'jsx-a11y/aria-activedescendant-has-tabindex': 'error',
         'jsx-a11y/aria-props': 'error',
         'jsx-a11y/aria-proptypes': 'error',
         'jsx-a11y/aria-role': 'error',
         'jsx-a11y/aria-unsupported-elements': 'error',
         'jsx-a11y/click-events-have-key-events': 'error',
         'jsx-a11y/heading-has-content': 'error',
-        'jsx-a11y/href-no-hash': 'error',
         'jsx-a11y/html-has-lang': 'error',
         'jsx-a11y/iframe-has-title': 'error',
         'jsx-a11y/img-redundant-alt': 'error',
@@ -171,7 +170,6 @@ module.exports = {
         'jsx-a11y/aria-unsupported-elements': 'error',
         'jsx-a11y/click-events-have-key-events': 'error',
         'jsx-a11y/heading-has-content': 'error',
-        'jsx-a11y/href-no-hash': 'error',
         'jsx-a11y/html-has-lang': 'error',
         'jsx-a11y/iframe-has-title': 'error',
         'jsx-a11y/img-redundant-alt': 'error',