Merge pull request #426 from jessebeach/fix-aria-errormessage

Fix aria-errormessage attribute failure in aria-props for input tags

Author: jessebeach

__mocks__/genInteractives.js

@@ -95,6 +95,7 @@ const nonInteractiveElementsMap = {
   pre: [],
   progress: [],
   ruby: [],
+  section: [],
   table: [],
   tbody: [],
   td: [],

__tests__/src/rules/aria-props-test.js

@@ -53,6 +53,7 @@ ruleTester.run('aria-props', rule, {
     { code: '<div fooaria-foobar="true"></div>' },
     { code: '<div fooaria-hidden="true"></div>' },
     { code: '<Bar baz />' },
+    { code: '<input type="text" aria-errormessage="foobar" />' },
   ].concat(basicValidityTests).map(parserOptionsMapper),
   invalid: [
     { code: '<div aria-="foobar" />', errors: [errorMessage('aria-')] },

__tests__/src/rules/no-noninteractive-element-interactions-test.js

@@ -140,7 +140,6 @@ const alwaysValid = [
   { code: '<s onClick={() => {}} />;' },
   { code: '<samp onClick={() => {}} />;' },
   { code: '<script onClick={() => {}} />;' },
-  { code: '<section onClick={() => {}} />;' },
   { code: '<small onClick={() => {}} />;' },
   { code: '<source onClick={() => {}} />;' },
   { code: '<spacer onClick={() => {}} />;' },
@@ -196,7 +195,6 @@ const alwaysValid = [
   { code: '<div role="landmark" onClick={() => {}} />;' },
   { code: '<div role="range" onClick={() => {}} />;' },
   { code: '<div role="roletype" onClick={() => {}} />;' },
-  { code: '<div role="section" onClick={() => {}} />;' },
   { code: '<div role="sectionhead" onClick={() => {}} />;' },
   { code: '<div role="select" onClick={() => {}} />;' },
   { code: '<div role="structure" onClick={() => {}} />;' },
@@ -291,6 +289,7 @@ const neverValid = [
   { code: '<pre onClick={() => {}} />;', errors: [expectedError] },
   { code: '<progress onClick={() => {}} />;', errors: [expectedError] },
   { code: '<ruby onClick={() => {}} />;', errors: [expectedError] },
+  { code: '<section onClick={() => {}} />;', errors: [expectedError] },
   { code: '<table onClick={() => {}} />;', errors: [expectedError] },
   { code: '<tbody onClick={() => {}} />;', errors: [expectedError] },
   { code: '<td onClick={() => {}} />;', errors: [expectedError] },

__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js

@@ -206,7 +206,6 @@ const alwaysValid = [
   { code: '<s role="button" />;' },
   { code: '<samp role="button" />;' },
   { code: '<script role="button" />;' },
-  { code: '<section role="button" />;' },
   { code: '<small role="button" />;' },
   { code: '<source role="button" />;' },
   { code: '<spacer role="button" />;' },
@@ -420,6 +419,7 @@ const neverValid = [
   { code: '<nav role="menuitem" />;', errors: [expectedError] },
   { code: '<ol role="menuitem" />;', errors: [expectedError] },
   { code: '<p role="button" />;', errors: [expectedError] },
+  { code: '<section role="button" />;', errors: [expectedError] },
   { code: '<table role="menuitem" />;', errors: [expectedError] },
   { code: '<tbody role="menuitem" />;', errors: [expectedError] },
   { code: '<td role="menuitem" />;', errors: [expectedError] },

__tests__/src/rules/no-static-element-interactions-test.js

@@ -157,7 +157,6 @@ const alwaysValid = [
   { code: '<div role="landmark" onClick={() => {}} />;' },
   { code: '<div role="range" onClick={() => {}} />;' },
   { code: '<div role="roletype" onClick={() => {}} />;' },
-  { code: '<div role="section" onClick={() => {}} />;' },
   { code: '<div role="sectionhead" onClick={() => {}} />;' },
   { code: '<div role="select" onClick={() => {}} />;' },
   { code: '<div role="structure" onClick={() => {}} />;' },
@@ -198,6 +197,7 @@ const alwaysValid = [
   { code: '<div role="region" onClick={() => {}} />;' },
   { code: '<div role="row" onClick={() => {}} />;' },
   { code: '<div role="rowgroup" onClick={() => {}} />;' },
+  { code: '<div role="section" onClick={() => {}} />;' },
   { code: '<div role="search" onClick={() => {}} />;' },
   { code: '<div role="separator" onClick={() => {}} />;' },
   { code: '<div role="scrollbar" onClick={() => {}} />;' },
@@ -318,7 +318,6 @@ const neverValid = [
   { code: '<s onClick={() => {}} />;', errors: [expectedError] },
   { code: '<samp onClick={() => {}} />;', errors: [expectedError] },
   { code: '<script onClick={() => {}} />;', errors: [expectedError] },
-  { code: '<section onClick={() => {}} />;', errors: [expectedError] },
   { code: '<small onClick={() => {}} />;', errors: [expectedError] },
   { code: '<source onClick={() => {}} />;', errors: [expectedError] },
   { code: '<spacer onClick={() => {}} />;', errors: [expectedError] },

package.json

@@ -60,7 +60,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "aria-query": "^2.0.0",
+    "aria-query": "^3.0.0",
     "array-includes": "^3.0.3",
     "ast-types-flow": "^0.0.7",
     "axobject-query": "^2.0.1",