Skip to content

Conversation

@odow
Copy link
Member

@odow odow commented Oct 21, 2025

x-ref #330 (comment)

These methods are not necessary:

Now there's a different argument for keeping these if/when the set gets added to MOI proper (#330 (comment)), but SCS.jl is not the place for them.

@odow odow requested a review from blegat October 21, 2025 08:01
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (333120f) to head (a242092).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   92.16%   96.34%   +4.17%     
==========================================
  Files          12       12              
  Lines         689      656      -33     
==========================================
- Hits          635      632       -3     
+ Misses         54       24      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit 2dee220 into master Oct 21, 2025
12 checks passed
@odow odow deleted the od/coverage branch October 21, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants