Improve code coverage #332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref #330 (comment)
These methods are not necessary:
function_constantsis used only when getting the function, where as we get theAmatrix directly.dot_coefficientsis used only when getting the variable dual, which SCS doesn't support: https://github.com/jump-dev/MathOptInterface.jl/blob/ec8434e5a4813c26a05ce6300b2591b36b82b6f1/src/Utilities/results.jl#L413-L422set_dotis used only when computing the dual objective value via the fallback, which we compute directly.Now there's a different argument for keeping these if/when the set gets added to MOI proper (#330 (comment)), but SCS.jl is not the place for them.