Add tests to get 100% code coverage (#32)

Author: odow

src/MOI_wrapper.jl

@@ -3,8 +3,6 @@
 # Use of this source code is governed by an MIT-style license that can be found
 # in the LICENSE.md file or at https://opensource.org/licenses/MIT.
 
-import MathOptInterface as MOI
-
 const MAX_MAJITER = 100_000
 const MAX_ITER = 10_000_000
 
@@ -84,6 +82,7 @@ function MOI.supports(::Optimizer, param::MOI.RawOptimizerAttribute)
     return haskey(PIECES_MAP, param.name) ||
            hasfield(Parameters, Symbol(param.name))
 end
+
 function MOI.set(optimizer::Optimizer, param::MOI.RawOptimizerAttribute, value)
     if !MOI.supports(optimizer, param)
         throw(MOI.UnsupportedAttribute(param))
@@ -107,6 +106,7 @@ function MOI.set(optimizer::Optimizer, param::MOI.RawOptimizerAttribute, value)
     end
     return
 end
+
 function MOI.get(optimizer::Optimizer, param::MOI.RawOptimizerAttribute)
     if !MOI.supports(optimizer, param)
         throw(MOI.UnsupportedAttribute(param))
@@ -124,6 +124,7 @@ function MOI.get(optimizer::Optimizer, param::MOI.RawOptimizerAttribute)
 end
 
 MOI.supports(::Optimizer, ::MOI.Silent) = true
+
 function MOI.set(optimizer::Optimizer, ::MOI.Silent, value::Bool)
     optimizer.silent = value
     return
@@ -198,17 +199,6 @@ function MOI.supports_constraint(
     return true
 end
 
-function _isless(t1::MOI.VectorAffineTerm, t2::MOI.VectorAffineTerm)
-    if t1.scalar_term.variable.value == t2.scalar_term.variable.value
-        return isless(t1.output_index, t2.output_index)
-    else
-        return isless(
-            t1.scalar_term.variable.value,
-            t2.scalar_term.variable.value,
-        )
-    end
-end
-
 function _next(model::Optimizer, i)
     for j in (i+1):length(model.Ainfo_entptr)
         if !isempty(model.Ainfo_entptr[j])
@@ -354,6 +344,7 @@ function MOI.get(optimizer::Optimizer, ::MOI.RawStatusString)
         optimizer.pieces
     return "majiter = $majiter, iter = $iter, λupdate = $λupdate, CG = $CG, curr_CG = $curr_CG, totaltime = $totaltime, σ = $σ, overallsc = $overallsc"
 end
+
 function MOI.get(optimizer::Optimizer, ::MOI.SolveTimeSec)
     return MOI.get(optimizer, MOI.RawOptimizerAttribute("totaltime"))
 end
@@ -477,6 +468,7 @@ function MOI.get(model::Optimizer, ::MOI.ResultCount)
 end
 
 struct Factor <: MOI.AbstractConstraintAttribute end
+
 MOI.is_set_by_optimize(::Factor) = true
 
 function MOI.get(

src/SDPLR.jl

@@ -5,6 +5,7 @@
 
 module SDPLR
 
+import MathOptInterface as MOI
 import SDPLR_jll
 
 include("bounds.jl")

test/MOI_wrapper.jl

@@ -50,6 +50,45 @@ function test_runtests()
     return
 end
 
+function test_RawOptimizerAttribute_UnsupportedAttribute()
+    model = SDPLR.Optimizer()
+    attr = MOI.RawOptimizerAttribute("FooBarBaz")
+    @test !MOI.supports(model, attr)
+    @test_throws MOI.UnsupportedAttribute(attr) MOI.get(model, attr)
+    @test_throws MOI.UnsupportedAttribute(attr) MOI.set(model, attr, false)
+    return
+end
+
+function test_RawOptimizerAttribute_PIECES_MAP_nothing()
+    model = SDPLR.Optimizer()
+    attr = MOI.RawOptimizerAttribute("lambdaupdate")
+    @test MOI.supports(model, attr)
+    @test MOI.get(model, attr) === nothing
+    @test MOI.set(model, attr, 2.0) === nothing
+    @test MOI.get(model, attr) === 2.0
+    @test MOI.set(model, attr, nothing) === nothing
+    @test MOI.get(model, attr) === nothing
+    return
+end
+
+function test_Ainfo_entptr_in_mixed_order()
+    model = SDPLR.Optimizer()
+    set = MOI.PositiveSemidefiniteConeTriangle(2)
+    x, c = MOI.add_constrained_variables(model, set)
+    MOI.add_constraint.(model, 1.0 .* x, MOI.EqualTo.([1.0, -1.0, 2.0]))
+    y, _ = MOI.add_constrained_variables(model, set)
+    MOI.add_constraint.(model, 1.0 .* y, MOI.EqualTo.([1.0, 2.0, 6.0]))
+    MOI.set(model, MOI.ObjectiveSense(), MOI.MIN_SENSE)
+    f = sum(1.0 * x) + sum(1.0 * y)
+    MOI.set(model, MOI.ObjectiveFunction{typeof(f)}(), f)
+    MOI.optimize!(model)
+    @test MOI.get(model, MOI.TerminationStatus()) == MOI.LOCALLY_SOLVED
+    atol = 1e-4
+    @test ≈(MOI.get.(model, MOI.VariablePrimal(), x), [1.0, -1.0, 2.0]; atol)
+    @test ≈(MOI.get.(model, MOI.VariablePrimal(), y), [1.0, 2.0, 6.0]; atol)
+    return
+end
+
 function runtests()
     for name in names(@__MODULE__; all = true)
         if startswith("$(name)", "test_")