Add self-tests for assert[Not]Equals() with arrays

Author: sormuras

junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionUtils.java

@@ -114,6 +114,9 @@ static boolean objectsAreEqual(@Nullable Object obj1, @Nullable Object obj2) {
 		if (obj1 == null) {
 			return (obj2 == null);
 		}
+		//		if (obj1.getClass().isArray() && (obj2 != null && obj2.getClass().isArray())) {
+		//			throw new AssertionError("Should have used `assertArrayEquals()?!`");
+		//		}
 		return obj1.equals(obj2);
 	}
 

jupiter-tests/src/test/java/org/junit/jupiter/api/AssertEqualsAssertionsTests.java

@@ -13,6 +13,7 @@
 import static org.junit.jupiter.api.AssertionTestUtils.assertExpectedAndActualValues;
 import static org.junit.jupiter.api.AssertionTestUtils.assertMessageEndsWith;
 import static org.junit.jupiter.api.AssertionTestUtils.assertMessageEquals;
+import static org.junit.jupiter.api.AssertionTestUtils.assertMessageMatches;
 import static org.junit.jupiter.api.AssertionTestUtils.assertMessageStartsWith;
 import static org.junit.jupiter.api.AssertionTestUtils.expectAssertionFailedError;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -750,6 +751,31 @@ void chars() {
 
 	}
 
+	@Nested
+	class ArraysAsArguments {
+		@Test
+		void objects() {
+			Object object = new Object();
+			Object array1 = new Object[] { object };
+			Object array2 = new Object[] { object };
+			try {
+				assertEquals(array1, array2);
+				expectAssertionFailedError();
+			}
+			catch (AssertionFailedError ex) {
+				assertMessageMatches(ex, "expected: " + //
+						"\\Q[Ljava.lang.Object;@\\E" + //
+						".+" + //
+						"\\Q<[java.lang.Object@\\E.+" + //
+						"\\Q]> but was: [Ljava.lang.Object;@\\E" + //
+						".+" + //
+						"\\Q<[java.lang.Object@\\E" + //
+						".+" + //
+						"\\Q]>\\E");
+			}
+		}
+	}
+
 	// -------------------------------------------------------------------------
 
 	@SuppressWarnings("overrides")

jupiter-tests/src/test/java/org/junit/jupiter/api/AssertNotEqualsAssertionsTests.java

@@ -624,6 +624,17 @@ void assertNotEqualsInvokesEqualsMethodForIdenticalObjects() {
 
 	}
 
+	@Nested
+	class AssertNotEqualsArrays {
+		@Test
+		void objects() {
+			Object object = new Object();
+			Object array1 = new Object[] { object };
+			Object array2 = new Object[] { object };
+			assertNotEquals(array1, array2);
+		}
+	}
+
 	// -------------------------------------------------------------------------
 
 	@Nested