Update font handling #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
I can't say I like it, since I do prefer the other font, but that change is welcome since less opinionated. I'll probably allow to configure it in a follow up PR |
jtpio
force-pushed
the
update-font-handling
branch
from
8de231d to
62cf611
Compare
Member
Author
|
Yes it would be great to allow configuring the font 👍 Maybe that could be done with
|
Member
Author
|
CI passing and looking good on Binder:
|
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #16
Fixes #11
Defaults back to the font family from the extension template:
https://github.com/jupyterlab/extension-template/blob/8e943a2997a04d66ead2064a90a12903beb8b09c/template/style/%7B%25%20if%20kind%20%3D%3D%20'theme'%20%25%7Dvariables.css%7B%25%20endif%20%25%7D#L111-L112