Fix - Error on hide when popover is not shown

kamranahmedse · kamranahmedse · commit 9c7753715bd2 · 2019-03-04T10:17:44.000+04:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "driver.js",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "description": "A light-weight, no-dependency, vanilla JavaScript library to drive the user's focus across the page",
   "main": "dist/driver.min.js",
   "types": "types/index.d.ts",
diff --git a/src/core/popover.js b/src/core/popover.js
@@ -91,6 +91,11 @@ export default class Popover extends Element {
    * @public
    */
   hide() {
+    // If hide is called when the node isn't created yet
+    if (!this.node) {
+      return;
+    }
+
     this.node.style.display = 'none';
   }
 
diff --git a/src/index.js b/src/index.js
@@ -145,7 +145,6 @@ export default class Driver {
     }
   }
 
-
   /**
    * Handler for the onResize DOM event
    * Makes sure highlighted element stays at valid position

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "driver.js",`
`3`		`- "version": "0.9.3",`
	`3`	`+ "version": "0.9.4",`
`4`	`4`	`"description": "A light-weight, no-dependency, vanilla JavaScript library to drive the user's focus across the page",`
`5`	`5`	`"main": "dist/driver.min.js",`
`6`	`6`	`"types": "types/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,6 @@ export default class Driver {`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
`148`		`-`
`149`	`148`	`/**`
`150`	`149`	`* Handler for the onResize DOM event`
`151`	`150`	`* Makes sure highlighted element stays at valid position`