Skip to content

Add tests #3

@kenchris

Description

@kenchris

There are a few optimizations that can be done, like I believe there is an invalidate call too much and a call to typeFn too much. But tests would make sure that we don't break anything when making such changes.

  • attr sets prop (if has attrName) - for all types
  • prop sets attr (if has attrName)
  • defined prop-change calls invalidate - otherwise not
  • attr-change calls invalidate if defined in prop and has attrName defined - otherwise not (also if attrName !== propName)
  • $() finds the correct element - also after invalidation where that element is changed, removed or added
  • Multiple invalidate calls (scope + events handlers) in same execution of the event loop only calls 1x render.

Also use web components polyfill to test on Firefox

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions