remove superfluous nested attr rejects

Author: ezekg

app/models/machine.rb

@@ -45,7 +45,7 @@ class ResurrectionExpiredError < StandardError; end
 
   denormalizes :policy_id, from: :license
 
-  accepts_nested_attributes_for :components, limit: 20, reject_if: :reject_associated_records_for_components
+  accepts_nested_attributes_for :components, limit: 20
   tracks_nested_attributes_for :components
 
   # Machines firstly automatically inherit their license's group ID.
@@ -829,16 +829,6 @@ def default_proof_dataset
     }
   end
 
-  def reject_associated_records_for_components(attrs)
-    return if
-      new_record?
-
-    components.exists?(
-      # Make sure we only select real columns, not e.g. _destroy.
-      attrs.slice(attributes.keys),
-    )
-  end
-
   # atomically update license's counter caches on machine create, update, and destroy
   # FIXME(ezekg) move this into an attribute counter cache concern?
   {

app/models/release.rb

@@ -101,7 +101,7 @@ class Release < ApplicationRecord
   has_environment default: -> { product&.environment_id }
   has_account default: -> { product&.account_id }, inverse_of: :releases
 
-  accepts_nested_attributes_for :constraints, limit: 20, reject_if: :reject_associated_records_for_constraints
+  accepts_nested_attributes_for :constraints, limit: 20
   tracks_nested_attributes_for :constraints
 
   accepts_nested_attributes_for :channel
@@ -917,16 +917,6 @@ def validate_associated_records_for_channel
     self.channel = rows.first
   end
 
-  def reject_associated_records_for_constraints(attrs)
-    return if
-      new_record?
-
-    constraints.exists?(
-      # Make sure we only select real columns, not e.g. _destroy.
-      attrs.slice(attributes.keys),
-    )
-  end
-
   def enforce_release_limit_on_account!
     return unless account.trialing_or_free?
 

app/models/role.rb

@@ -45,7 +45,7 @@ def actions = loaded? ? collect(&:action) : super
     allow_nil: true,
     to: :resource
 
-  accepts_nested_attributes_for :role_permissions, reject_if: :reject_associated_records_for_role_permissions
+  accepts_nested_attributes_for :role_permissions
   tracks_nested_attributes_for :role_permissions
 
   # Set default permissions unless already set
@@ -226,18 +226,6 @@ def set_default_permissions
     )
   end
 
-  ##
-  # reject_associated_records_for_role_permissions rejects duplicate role permissions.
-  def reject_associated_records_for_role_permissions(attrs)
-    return if
-      new_record?
-
-    role_permissions.exists?(
-      # Make sure we only select real columns, not e.g. _destroy.
-      attrs.slice(attributes.keys),
-    )
-  end
-
   ##
   # autosave_associated_records_for_role_permissions bulk inserts role permissions instead
   # of saving them sequentially, which is incredibly slow with 100+ permissions.

app/models/token.rb

@@ -45,7 +45,7 @@ def actions = loaded? ? collect(&:action) : super
     # Default to wildcard permission but allow all
     default: %w[*]
 
-  accepts_nested_attributes_for :token_permissions, reject_if: :reject_associated_records_for_token_permissions
+  accepts_nested_attributes_for :token_permissions
   tracks_nested_attributes_for :token_permissions
 
   tracks_attributes :expiry
@@ -440,18 +440,6 @@ def set_default_expiry
                   end
   end
 
-  ##
-  # reject_associated_records_for_token_permissions rejects duplicate token permissions.
-  def reject_associated_records_for_token_permissions(attrs)
-    return if
-      new_record?
-
-    token_permissions.exists?(
-      # Make sure we only select real columns, not e.g. _destroy.
-      attrs.slice(attributes.keys),
-    )
-  end
-
   ##
   # autosave_associated_records_for_token_permissions bulk inserts token permissions instead
   # of saving them sequentially, which is incredibly slow with 100+ permissions.