fix(update): improve type safety for release notes handling

michiosw · michiosw · commit 21630152206c · 2025-07-18T13:26:24.000+02:00
- Handle null values in release notes array properly
- Convert null notes to empty strings instead of 'null'
- Prevents potential runtime issues with malformed release notes
diff --git a/apps/electron-app/src/main/services/update-service.ts b/apps/electron-app/src/main/services/update-service.ts
@@ -183,7 +183,7 @@ export default class AppUpdater {
     if (typeof releaseNotes === "string") {
       notes = releaseNotes;
     } else {
-      notes = releaseNotes.map(note => note.note).join("\n");
+      notes = releaseNotes.map(note => note.note || "").join("\n");
     }
 
     // Strip HTML tags and format for native dialog

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ export default class AppUpdater {`
`183`	`183`	`if (typeof releaseNotes === "string") {`
`184`	`184`	`notes = releaseNotes;`
`185`	`185`	`} else {`
`186`		`- notes = releaseNotes.map(note => note.note).join("\n");`
	`186`	`+ notes = releaseNotes.map(note => note.note \|\| "").join("\n");`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`// Strip HTML tags and format for native dialog`