Skip to content

Commit 8fc1de8

Browse files
committed
fix: fix autocomplete bug and added course image placeholder
1 parent 5c144ad commit 8fc1de8

File tree

6 files changed

+12
-6
lines changed

6 files changed

+12
-6
lines changed

k8s/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v1
22
description: A Helm chart for kube-ts-react-client
33
name: kube-ts-react-client
44
version: 1.0.0
5-
appVersion: 1.5.14
5+
appVersion: 1.5.17
66
home: https://cloud.docker.com/u/kubejs/repository/docker/kubejs/kube-ts-react-client
77
icon: https://avatars2.githubusercontent.com/u/47761918?s=200&v=4
88
sources:

k8s/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ replicaCount: 2
66

77
image:
88
repository: kubejs/kube-ts-react-client
9-
tag: 1.5.14
9+
tag: 1.5.17
1010
pullPolicy: Always
1111
containerPort: 80
1212

src/components/CourseSlide/index.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@ import {
77
Typography,
88
} from '@material-ui/core';
99
import _find from 'ramda/src/find';
10+
import _isNil from 'ramda/src/isNil';
1011
import _propEq from 'ramda/src/propEq';
1112
import React from 'react';
1213
import { Link } from 'react-router-dom';
1314
// tslint:disable:no-import-side-effect
1415
import 'slick-carousel/slick/slick-theme.css';
1516
import 'slick-carousel/slick/slick.css';
1617
import CourseRating from '../../atoms/CourseRating';
18+
import courseImagePlaceholder from '../../images/course_400x180.png';
1719
import { EnhancedCourse } from '../../redux/discoveryItems/actionCreators';
1820
import assetsUrl from '../../utils/helpers/assetsUrl';
1921

@@ -29,12 +31,14 @@ const Slide = ({
2931
// tslint:disable-next-line:no-magic-numbers
3032
const coursePrice = Number(Math.random() * 10 + 9).toFixed(2);
3133

34+
const imageUrl = !_isNil(course.imageUrl) ? assetsUrl(course.imageUrl) : courseImagePlaceholder;
35+
3236
return (
3337
<Card className={classes.card}>
3438
<Link className={classes.courseLink} to={`/courses/${course.slug}`}>
3539
<CardMedia
3640
className={classes.cardMedia}
37-
image={assetsUrl(course.imageUrl)}
41+
image={imageUrl}
3842
title="Image title"
3943
/>
4044
<CardContent className={classes.cardContent}>

src/components/CourseView/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
// tslint:disable:no-magic-numbers
22
import { Avatar, Button, Container, Grid, Paper } from '@material-ui/core';
3+
import _isNil from 'ramda/src/isNil';
34
import React, { memo, useEffect } from 'react';
45
import { useDispatch, useSelector } from 'react-redux';
56
import { RouteComponentProps } from 'react-router';
67
import { Redirect } from 'react-router-dom';
78
import { ROOT } from '../../constants/routes';
9+
import courseImagePlaceholder from '../../images/course_400x180.png';
810
import { getCourseDetailsRequested } from '../../redux/courseDetails/actionCreators';
911
import { State } from '../../redux/rootReducer';
1012
import assetsUrl from '../../utils/helpers/assetsUrl';
@@ -34,7 +36,7 @@ const CourseView = ({ match }: RouteComponentProps<Params>) => {
3436
// TODO: make course placeholder
3537
return <div>Loading...</div>;
3638
}
37-
39+
const imageUrl = !_isNil(course.imageUrl) ? assetsUrl(course.imageUrl) : courseImagePlaceholder;
3840
const coursePrice = Number(Math.random() * 10 + 9).toFixed(2);
3941

4042
return (
@@ -60,7 +62,7 @@ const CourseView = ({ match }: RouteComponentProps<Params>) => {
6062
</Grid>
6163
<Grid item xs={12} sm={3}>
6264
<Paper className={classes.paper}>
63-
<img src={assetsUrl(course.imageUrl)} style={{ width: '100%' }} />
65+
<img src={imageUrl} style={{ width: '100%' }} />
6466
<h4>{${coursePrice}`}</h4>
6567
<Button variant="contained" fullWidth color="primary">
6668
Add to cart

src/config/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const env = (window as any)._env_;
1111

1212
const config: Config = {
1313
apiUrl: getStringValue(env.REACT_APP_API_URL, 'http://localhost:9000/api/v1'),
14-
assetsUrl: getStringValue(env.REACT_APP_ASSETS_URL, 'http://localhost:3000'),
14+
assetsUrl: getStringValue(env.REACT_APP_ASSETS_URL, '/'),
1515
logger: {
1616
dummy: {
1717
silent:

src/images/course_400x180.png

1.06 KB
Loading

0 commit comments

Comments
 (0)