Skip to content

Commit 9b8dd48

Browse files
committed
Fix crash in podgroup when runLauncherAsWorker is true
Signed-off-by: GonzaloSaez <[email protected]>
1 parent c738a83 commit 9b8dd48

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pkg/controller/podgroup.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,11 @@ func calPGMinResource(minMember *int32, mpiJob *kubeflow.MPIJob, pcLister schedu
356356

357357
sort.Sort(sort.Reverse(order))
358358
// Launcher + Worker > minMember
359+
replicas := *order[0].Replicas
360+
if len(order) > 1 {
361+
// When using runLauncherAsWorker, there may be no worker.
362+
replicas += *order[1].Replicas
363+
}
359364
if minMember != nil && *order[0].Replicas+*order[1].Replicas > *minMember {
360365
// If the launcher and workers have the same priority, it treats workers as a lower priority.
361366
if order[0].priority == order[1].priority {

0 commit comments

Comments
 (0)