Skip to content

Commit f94d911

Browse files
committed
fix: remove all deferUpdates references after field removal
- Regenerate swagger docs (docs.go) to remove deferUpdates - Remove deferUpdates from sample workspace YAML - Update test comments to remove deferUpdates references - Update backend README example to remove deferUpdates - Update frontend package-lock.json Signed-off-by: alokdangre <[email protected]>
1 parent b965498 commit f94d911

File tree

5 files changed

+658
-1222
lines changed

5 files changed

+658
-1222
lines changed

workspaces/backend/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ curl -X POST http://localhost:4000/api/v1/workspaces/default \
9393
"name": "dora",
9494
"kind": "jupyterlab",
9595
"paused": false,
96-
"deferUpdates": false,
9796
"podTemplate": {
9897
"podMetadata": {
9998
"labels": {

workspaces/backend/openapi/docs.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1742,7 +1742,6 @@ const docTemplate = `{
17421742
"type": "object",
17431743
"required": [
17441744
"activity",
1745-
"deferUpdates",
17461745
"name",
17471746
"namespace",
17481747
"paused",
@@ -1758,9 +1757,6 @@ const docTemplate = `{
17581757
"activity": {
17591758
"$ref": "#/definitions/workspaces.Activity"
17601759
},
1761-
"deferUpdates": {
1762-
"type": "boolean"
1763-
},
17641760
"name": {
17651761
"type": "string"
17661762
},
@@ -1799,16 +1795,12 @@ const docTemplate = `{
17991795
"workspaces.WorkspaceCreate": {
18001796
"type": "object",
18011797
"required": [
1802-
"deferUpdates",
18031798
"kind",
18041799
"name",
18051800
"paused",
18061801
"podTemplate"
18071802
],
18081803
"properties": {
1809-
"deferUpdates": {
1810-
"type": "boolean"
1811-
},
18121804
"kind": {
18131805
"type": "string"
18141806
},

workspaces/controller/internal/controller/workspace_controller_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,7 @@ var _ = Describe("Workspace Controller", func() {
216216
// - when adding a redirect to the currently selected `imageConfig` or `podConfig`
217217
// - if the workspace is NOT paused, NO resource changes are made except setting `status.pendingRestart`
218218
// and `status.podTemplateOptions` (`desired` along with `redirectChain`)
219-
// - if the workspace IS paused, but `deferUpdates` is true, the same as above
220-
// - if the workspace IS paused and `deferUpdates` is false:
219+
// - if the workspace IS paused:
221220
// - the selected options (under `spec`) should be changed to the redirect
222221
// and `status.pendingRestart` should become false, and `podTemplateOptions` should be empty
223222
// - the new options should be applied to the StatefulSet

workspaces/controller/manifests/kustomize/samples/jupyterlab_v1beta1_workspace.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ spec:
66
## if the workspace is paused (no pods running)
77
paused: false
88

9-
## if true, pending updates are NOT applied when the Workspace is paused
10-
## if false, pending updates are applied when the Workspace is paused
11-
deferUpdates: false
12-
139
## the WorkspaceKind to use
1410
kind: "jupyterlab"
1511

0 commit comments

Comments
 (0)