Address PR comments.

Author: godwinpang

pkg/internal/controller/controller.go

@@ -337,8 +337,7 @@ func (c *Controller[request]) startEventSourcesAndQueueLocked(ctx context.Contex
 					defer close(sourceStartErrChan)
 					log.Info("Starting EventSource")
 
-					q := c.Queue
-					if err := watch.Start(ctx, q); err != nil {
+					if err := watch.Start(ctx, c.Queue); err != nil {
 						sourceStartErrChan <- err
 						return
 					}

pkg/leaderelection/fake/leader_election.go

@@ -39,10 +39,9 @@ type ControllableResourceLockInterface interface {
 
 	// BlockLeaderElection blocks the leader election process when called. It will not be unblocked
 	// until UnblockLeaderElection is called.
-	// Not thread safe.
 	BlockLeaderElection()
 
-	// UnblockLeaderElection unblocks the leader election. Not thread safe.
+	// UnblockLeaderElection unblocks the leader election.
 	UnblockLeaderElection()
 }
 

pkg/manager/manager_test.go

@@ -1997,7 +1997,7 @@ var _ = Describe("manger.Manager", func() {
 		By("Unblocking leader election")
 		resourceLockWithHooks.UnblockLeaderElection()
 
-		By("Waiting for the leader election runnable to be executed without leader election being won")
+		By("Waiting for the leader election runnable to be executed after leader election was won")
 		<-m.Elected()
 		Expect(<-runnableExecutionOrderChan).To(Equal(leaderElectionRunnableName))
 	})