address comments

Author: jingyih

pkg/manager/runnable_group.go

@@ -245,16 +245,19 @@ func (r *runnableGroup) reconcile() {
 
 			// Start the runnable.
 			if err := rn.Start(r.ctx); err != nil {
-				// Send error with context awareness to prevent blocking during shutdown
-				select {
-				case r.errChan <- err:
-					// Error sent successfully
-				case <-r.ctx.Done():
-					// Context cancelled (shutdown), drop error to prevent blocking forever
-					// This prevents goroutine leaks when error drain go routine has exited after timeout
+				// Check if we're in shutdown mode
+				r.stop.RLock()
+				isStopped := r.stopped
+				r.stop.RUnlock()
+
+				if isStopped {
+					// During shutdown, drop errors to prevent goroutine leaks
 					if !errors.Is(err, context.Canceled) { // don't log context.Canceled errors as they are expected during shutdown
 						r.logger.Info("error dropped during shutdown to prevent goroutine leak", "error", err)
 					}
+				} else {
+					// During normal operation, always try to send errors (may block briefly)
+					r.errChan <- err
 				}
 			}
 		}(runnable)