Fixed integration tests

Author: krishagarwal278

pkg/analysis/noreferences/analyzer.go

@@ -30,7 +30,10 @@ const (
 	doc  = "Enforces that fields use Ref/Refs and not Reference/References"
 )
 
-var errUnexpectedInitializerType = errors.New("expected namingconventions.Initializer() to be of type initializer.ConfigurableAnalyzerInitializer, but was not")
+var (
+	errUnexpectedInitializerType = errors.New("expected namingconventions.Initializer() to be of type initializer.ConfigurableAnalyzerInitializer, but was not")
+	errInvalidPolicy             = errors.New("invalid policy")
+)
 
 // newAnalyzer creates a new analyzer for the noreferences linter that is a wrapper around the namingconventions linter.
 func newAnalyzer(cfg *Config) *analysis.Analyzer {
@@ -78,8 +81,6 @@ func buildConventions(policy Policy) []namingconventions.Convention {
 	switch policy {
 	case PolicyPreferAbbreviatedReference:
 		// Replace "Reference" or "References" with "Ref" or "Refs" anywhere in field name
-		// Case insensitive to handle lowercase in JSON tags
-		// Note: May produce false positives like "Preference" → "PRef", but this is acceptable
 		return []namingconventions.Convention{
 			{
 				Name:             "reference-to-ref",
@@ -92,8 +93,6 @@ func buildConventions(policy Policy) []namingconventions.Convention {
 
 	case PolicyNoReferences:
 		// Warn about reference words anywhere in field name without providing fixes
-		// Case insensitive to handle all variations
-		// Note: May flag false positives like "Preference", but user is warned to manually review
 		return []namingconventions.Convention{
 			{
 				Name:             "no-references",
@@ -105,6 +104,6 @@ func buildConventions(policy Policy) []namingconventions.Convention {
 
 	default:
 		// Should not happen due to validation
-		panic(fmt.Errorf("invalid policy: %s", policy))
+		panic(fmt.Errorf("%w: %s", errInvalidPolicy, policy))
 	}
 }

pkg/analysis/noreferences/config.go

@@ -15,7 +15,7 @@ limitations under the License.
 */
 package noreferences
 
-// policy defines the policy for handling references in field names.
+// Policy defines the policy for handling references in field names.
 type Policy string
 
 const (

tests/integration/testdata/default_configurations/volume.go

@@ -311,7 +311,7 @@ type ImageVolumeSource struct {
 	// This field is optional to allow higher level config management to default or override
 	// container images in workload controllers like Deployments and StatefulSets.
 	// +optional
-	Reference string `json:"reference,omitempty" protobuf:"bytes,1,opt,name=reference"` // want "optionalfields: field Reference should be a pointer."
+	Reference string `json:"reference,omitempty" protobuf:"bytes,1,opt,name=reference"` // want "optionalfields: field Reference should be a pointer." "noreferences: naming convention \"reference-to-ref\": field Reference: field names should use 'Ref' instead of 'Reference'"
 
 	// Policy for pulling OCI objects. Possible values are: // want "commentstart: godoc for field PullPolicy should start with 'pullPolicy ...'"
 	// Always: the kubelet always attempts to pull the reference. Container creation will fail If the pull fails.