Fixed test failures

Author: krishagarwal278

pkg/analysis/noreferences/analyzer.go

@@ -30,7 +30,10 @@ const (
 	doc  = "Enforces that fields use Ref/Refs and not Reference/References"
 )
 
-var errUnexpectedInitializerType = errors.New("expected namingconventions.Initializer() to be of type initializer.ConfigurableAnalyzerInitializer, but was not")
+var (
+	errUnexpectedInitializerType = errors.New("expected namingconventions.Initializer() to be of type initializer.ConfigurableAnalyzerInitializer, but was not")
+	errInvalidPolicy             = errors.New("invalid policy")
+)
 
 // newAnalyzer creates a new analyzer for the noreferences linter that is a wrapper around the namingconventions linter.
 func newAnalyzer(cfg *Config) *analysis.Analyzer {
@@ -105,6 +108,6 @@ func buildConventions(policy Policy) []namingconventions.Convention {
 
 	default:
 		// Should not happen due to validation
-		panic(fmt.Errorf("invalid policy: %s", policy))
+		panic(fmt.Errorf("%w: %s", errInvalidPolicy, policy))
 	}
 }

pkg/analysis/noreferences/config.go

@@ -15,7 +15,7 @@ limitations under the License.
 */
 package noreferences
 
-// policy defines the policy for handling references in field names.
+// Policy defines the policy for handling references in field names.
 type Policy string
 
 const (

pkg/analysis/noreferences/initializer.go

@@ -59,5 +59,6 @@ func validateConfig(cfg *Config, fldPath *field.Path) field.ErrorList {
 			[]string{string(PolicyPreferAbbreviatedReference), string(PolicyNoReferences)},
 		))
 	}
+
 	return errs
 }