Merge pull request #4975 from vitorfloriano/alpha-update-validation

🌱 (alpha update) add validation for equal versions

Author: k8s-ci-robot

pkg/cli/alpha/internal/update/validate.go

@@ -19,6 +19,7 @@ package update
 import (
 	"fmt"
 	"net/http"
+	"os"
 	"os/exec"
 	"strings"
 
@@ -28,6 +29,9 @@ import (
 
 // Validate checks the input info provided for the update and populates the cliVersion
 func (opts *Update) Validate() error {
+	if err := opts.validateEqualVersions(); err != nil {
+		return fmt.Errorf("failed to validate equal versions: %w", err)
+	}
 	if err := opts.validateGitRepo(); err != nil {
 		return fmt.Errorf("failed to validate git repository: %w", err)
 	}
@@ -117,3 +121,23 @@ func validateReleaseAvailability(version string) error {
 			resp.StatusCode, version)
 	}
 }
+
+// validateEqualVersions checks if from-version and to-version are the same.
+// If they are equal, logs an appropriate message and exits successfully.
+func (opts *Update) validateEqualVersions() error {
+	if opts.FromVersion == opts.ToVersion {
+		// Check if this is the latest version to provide appropriate message
+		latestVersion, err := fetchLatestRelease()
+		if err != nil {
+			return fmt.Errorf("failed to fetch latest release for messaging: %w", err)
+		}
+
+		if opts.ToVersion == latestVersion {
+			log.Infof("Your project already uses the latest version (%s). No action taken.", opts.FromVersion)
+		} else {
+			log.Infof("Your project already uses the specified version (%s). No action taken.", opts.FromVersion)
+		}
+		os.Exit(0)
+	}
+	return nil
+}

test/e2e/alphaupdate/update_test.go

@@ -161,6 +161,24 @@ var _ = Describe("kubebuilder", func() {
 			By("validating merge stopped in conflict state for manual resolution")
 			validateConflictState(mockProjectDir)
 		})
+
+		It("should succeed with no action when from-version and to-version are the same", func() {
+			By("creating mock project with kubebuilder v4.5.2")
+			createMockProject(mockProjectDir, pathBinFromVersion)
+
+			By("initializing git repository and committing mock project")
+			initializeGitRepo(mockProjectDir)
+
+			By("running alpha update with same versions (v4.5.2 to v4.5.2)")
+			cmd := exec.Command(kbc.BinaryName, "alpha", "update",
+				"--from-version", "v4.5.2", "--to-version", "v4.5.2", "--from-branch", "main")
+			cmd.Dir = mockProjectDir
+			output, err := cmd.CombinedOutput()
+
+			Expect(err).NotTo(HaveOccurred(), "Expected command to succeed when from-version equals to-version")
+			Expect(string(output)).To(ContainSubstring("already uses the specified version"))
+			Expect(string(output)).To(ContainSubstring("No action taken"))
+		})
 	})
 })