-
Notifications
You must be signed in to change notification settings - Fork 450
Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iomarsayed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @iomarsayed. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| TASProfileMixed: { | ||
| {Version: version.MustParse("0.10"), Default: false, PreRelease: featuregate.Alpha}, | ||
| {Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Deprecated}, | ||
| {Version: version.MustParse("0.11"), Default: true, PreRelease: featuregate.Deprecated}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should no longer be deprecated since enabled by default, I think it should be
a new entry rather than modifying old, so:
{Version: version.MustParse("0.10"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Deprecated},
{Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also adjust the KEP in the table https://github.com/kubernetes-sigs/kueue/pull/7144/files#diff-c8054619a353d0fc872425de6a22f0df62001353eb75f856d5ba504553b5fcbfR1075
cc @olekzabl
|
/release-note-edit |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Switch Default TAS Placement Algorithm from BestFit to Mixed, by enabling TAS Mixed Profile.
Which issue(s) this PR fixes:
Fixes #7214
Does this PR introduce a user-facing change?