refactor: silent removeFile if file not exist (#528)

Author: kukhariev

packages/core/src/storages/disk-storage.ts

@@ -105,7 +105,7 @@ export class DiskStorage extends BaseStorage<DiskFile> {
   async delete({ id }: FilePart): Promise<DiskFile[]> {
     try {
       const file = await this.getMeta(id);
-      await removeFile(this.getFilePath(file));
+      removeFile(this.getFilePath(file)).catch(() => null);
       await this.deleteMeta(id);
       return [{ ...file, status: 'deleted' }];
     } catch {}

packages/core/src/utils/fs.ts

@@ -28,8 +28,10 @@ export async function accessCheck(dir: string): Promise<void> {
  * Removes the specified file from the local file system
  */
 export async function removeFile(path: string): Promise<void> {
-  if (fsp.rm) return fsp.rm(path);
-  return fsp.unlink(path);
+  if (fsp.rm) return fsp.rm(path, { force: true });
+  return fsp.unlink(path).catch((err: NodeJS.ErrnoException): void => {
+    if (err.code !== 'ENOENT') throw err;
+  });
 }
 
 export function truncateFile(path: string, length = 0): Promise<void> {

test/util.spec.ts

@@ -81,6 +81,17 @@ describe('utils', () => {
     it('getWriteStream(not exist , 0)', () => {
       expect(() => utils.getWriteStream('', 0)).toThrow();
     });
+
+    it('removeFile(path)', async () => {
+      await utils.ensureFile(filepath);
+      await utils.removeFile(filepath);
+      expect(fs.existsSync(filepath)).toBe(false);
+    });
+
+    it('removeFile(not exist)', async () => {
+      await utils.removeFile(filepath);
+      expect(fs.existsSync(filepath)).toBe(false);
+    });
   });
 
   describe('http', () => {