Skip to content

Commit 1f47d27

Browse files
v2: fix pipeline (#338)
* refactor: remove incremental builds * refactor: decouple from pathe
1 parent 92714a4 commit 1f47d27

File tree

8 files changed

+7
-11
lines changed

8 files changed

+7
-11
lines changed

docs/src/routes/contributing/monorepo/index.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ The Vite configuration for the consuming application (`apps/docs`) is critical f
9494
* **`resolve.alias`:** This section **must** explicitly map the package names of your local `libs/*` dependencies directly to their `src` directories. While `vite-tsconfig-paths` might handle initial resolution using the root `tsconfig.json`, experience shows **this explicit aliasing in the Vite config is necessary for HMR to reliably detect and apply changes** made within the source files of linked local packages.
9595
* **Action:** When adding a new package (e.g., `@qds.dev/new-package`), add a corresponding alias:
9696
```typescript:apps/docs/vite.config.ts
97-
import { resolve } from "pathe";
97+
import { resolve } from "node:path";
9898

9999
resolve: {
100100
alias: {
@@ -123,7 +123,7 @@ For testing with Vitest, we need to ensure proper path resolution for local pack
123123

124124
* **Action:** When adding a new package, update the `resolve.alias` in the Vitest configuration:
125125
```typescript:vitest.config.ts
126-
import { resolve } from "pathe";
126+
import { resolve } from "node:path";
127127

128128
export default defineConfig({
129129
resolve: {

docs/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1+
import { resolve } from "node:path";
12
import { qdsTransformPlugin } from "@qds.dev/tools/rolldown";
23
import { asChild, icons } from "@qds.dev/tools/vite";
34
import { qwikVite } from "@qwik.dev/core/optimizer";
45
import { qwikRouter } from "@qwik.dev/router/vite";
56
import tailwindcss from "@tailwindcss/vite";
6-
import { resolve } from "pathe";
77
/**
88
* This is the base config for vite.
99
* When building, the adapter config is used which loads this file and extends it.

libs/components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"scripts": {
2424
"build": "pnpm run build.lib & pnpm run build.types",
2525
"build.lib": "rolldown -c rolldown.config.ts",
26-
"build.types": "tsc --emitDeclarationOnly --incremental --outDir ./lib-types",
26+
"build.types": "tsc --emitDeclarationOnly --outDir ./lib-types",
2727
"dev": "vite --mode ssr",
2828
"generate.styles": "node styles/tailwind/generate.ts",
2929
"qwik": "qwik"

libs/tools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"scripts": {
3434
"build": "pnpm run build.lib & pnpm run build.types && pnpm generate-icon-types",
3535
"build.lib": "rolldown -c rolldown.config.ts",
36-
"build.types": "tsc --emitDeclarationOnly --incremental --outDir ./lib-types",
36+
"build.types": "tsc --emitDeclarationOnly --outDir ./lib-types",
3737
"dev": "vite --mode ssr",
3838
"test": "vitest",
3939
"generate-icon-types": "node src/generate-icon-types.ts",

libs/utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"scripts": {
2525
"build": "pnpm run build.lib & pnpm run build.types",
2626
"build.lib": "rolldown -c rolldown.config.ts",
27-
"build.types": "tsc --emitDeclarationOnly --incremental --outDir ./lib-types",
27+
"build.types": "tsc --emitDeclarationOnly --outDir ./lib-types",
2828
"dev": "vite --mode ssr",
2929
"dev.debug": "node --inspect-brk ./node_modules/vite/bin/vite.js --mode ssr --force",
3030
"start": "vite --open --mode ssr",

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
"oxlint": "^1.24.0",
4040
"oxlint-tsgolint": "^0.3.0",
4141
"pagefind": "1.2.0",
42-
"pathe": "^2.0.3",
4342
"playwright": "^1.56.0",
4443
"vitest": "^4.0.3"
4544
},

pnpm-lock.yaml

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vitest.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import { resolve } from "node:path";
12
import { qdsTransformPlugin } from "@qds.dev/tools/rolldown";
23
import { qwikVite } from "@qwik.dev/core/optimizer";
34
import { playwright } from "@vitest/browser-playwright";
4-
import { resolve } from "pathe";
55
import { defineConfig, type TestProjectConfiguration } from "vitest/config";
66

77
const unitConfig: TestProjectConfiguration = {

0 commit comments

Comments
 (0)