Skip to content

Commit 5d199cb

Browse files
feat: until-found on collapsible, collapsible attrs, fix test flakiness, fix not selector for styles (#318)
* feat: updated collapsible attrs * test: browser tests * feat: hidden until found behavior * feat: collapsible data attrs * fix: types * feat: until found behavior of collapsible * fix: tree example * changesert
1 parent 7d9b34b commit 5d199cb

File tree

28 files changed

+1221
-1067
lines changed

28 files changed

+1221
-1067
lines changed

.changeset/empty-feet-fly.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
"@qds.dev/ui": patch
3+
---
4+
5+
### Collapsible Component Enhancements
6+
7+
- Added "hidden until found" behavior support for improved content discovery and browser search functionality
8+
- Updated data attributes for better state management and styling hooks
9+
- Enhanced collapsible attributes API
10+
11+
### Bug Fixes
12+
13+
- Fixed Tree component example
14+
- Fixed TypeScript type definitions
15+
16+
### Testing
17+
18+
- Added browser tests for improved component coverage

docs/src/routes/components/collapsible/examples/animation.tsx

Lines changed: 0 additions & 28 deletions
This file was deleted.

docs/src/routes/components/collapsible/examples/bind-open.tsx

Lines changed: 0 additions & 23 deletions
This file was deleted.

docs/src/routes/components/collapsible/examples/csr.tsx

Lines changed: 0 additions & 30 deletions
This file was deleted.

docs/src/routes/components/collapsible/examples/disabled.tsx

Lines changed: 0 additions & 22 deletions
This file was deleted.
Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,19 @@
11
import { Collapsible } from "@qds.dev/ui";
2-
import { component$, useStyles$ } from "@qwik.dev/core";
3-
import { LuChevronDown } from "@qwikest/icons/lucide";
2+
import { component$ } from "@qwik.dev/core";
43

54
export default component$(() => {
6-
useStyles$(styles);
7-
85
return (
9-
<Collapsible.Root class="collapsible">
10-
<Collapsible.Trigger class="collapsible-trigger">
11-
<span>Trigger</span>
12-
<LuChevronDown />
13-
</Collapsible.Trigger>
14-
<Collapsible.Content class="collapsible-content collapsible-content-outline ">
15-
Content
16-
</Collapsible.Content>
17-
</Collapsible.Root>
6+
<div>
7+
<p>Some visible text before</p>
8+
<Collapsible.Root>
9+
<Collapsible.Trigger class="not-ui-open:bg-red-500">
10+
Click to toggle
11+
</Collapsible.Trigger>
12+
<Collapsible.Content>
13+
<p>This is hidden searchable content that contains the word FINDME</p>
14+
</Collapsible.Content>
15+
</Collapsible.Root>
16+
<p>Some visible text after</p>
17+
</div>
1818
);
1919
});
20-
21-
// internal
22-
import styles from "../snippets/collapsible.css?inline";

docs/src/routes/components/collapsible/examples/open-change.tsx

Lines changed: 0 additions & 35 deletions
This file was deleted.

docs/src/routes/components/collapsible/examples/open.tsx

Lines changed: 0 additions & 22 deletions
This file was deleted.

docs/src/routes/components/collapsible/examples/programmatic.tsx

Lines changed: 0 additions & 29 deletions
This file was deleted.

docs/src/routes/components/collapsible/examples/svg.tsx

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)