Skip to content

Commit 5ac5242

Browse files
committed
fix(FR-1735): sftp application is always disabled. (#4726)
Resolves #4725 ([FR-1735](https://lablup.atlassian.net/browse/FR-1735)) # Add `system` session type to app launch check to prevent SFTP app from being falsely reported as disabled. This PR adds 'system' to the list of session types that support app launching. Previously, only 'batch', 'interactive', 'inference', and 'running' session types were considered for app support. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1735]: https://lablup.atlassian.net/browse/FR-1735?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 81b3705 commit 5ac5242

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

react/src/components/ComputeSessionNodeItems/SessionActionButtons.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const isActive = (session: SessionActionButtonsFragment$data) => {
6060
};
6161
const isAppSupported = (session: SessionActionButtonsFragment$data) => {
6262
return (
63-
['batch', 'interactive', 'inference', 'running'].includes(
63+
['batch', 'interactive', 'inference', 'system', 'running'].includes(
6464
session?.type || '',
6565
) && !_.isEmpty(JSON.parse(session?.service_ports ?? '{}'))
6666
);

0 commit comments

Comments
 (0)