fix: improve log clearing and prevent 404 errors

connermo · claude · connermo · commit 4454c47dab05 · 2025-11-03T17:14:14.000+08:00
This commit fixes critical issues with the log clearing functionality: Backend fixes: - Fixed DELETE request body parsing with proper default values - Added conversation queue routing for Celery tasks - Ensured proper handling of empty conversation_ids array Frontend fixes: - Fixed DELETE request body handling in HTTP client - Improved SWR cache invalidation with correct key matching - Added proactive conversation ID validation to prevent 404 errors - Simplified error handling and removed debug logging Key improvements: - Request body now always sent for DELETE (empty array vs undefined) - Multi-layer cache clearing (log list, explore apps, conversation data) - Auto-cleanup of stale conversation IDs from localStorage - Error handling for deleted conversations with 404 recovery All changes pass lint and type-check validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/api/controllers/console/app/conversation.py b/api/controllers/console/app/conversation.py
@@ -151,10 +151,14 @@ def get(self, app_model):
     def delete(self, app_model):
         current_user, _ = current_account_with_tenant()
         parser = reqparse.RequestParser()
-        parser.add_argument("conversation_ids", type=list, location="json", required=False)
+        parser.add_argument("conversation_ids", type=list, location="json", required=False, default=None)
         args = parser.parse_args()
 
-        conversation_ids = [str(id) for id in args["conversation_ids"]] if args.get("conversation_ids") else None
+        # Convert conversation IDs to strings if provided and non-empty
+        conversation_ids_raw = args.get("conversation_ids")
+        conversation_ids = (
+            [str(id) for id in conversation_ids_raw] if conversation_ids_raw and len(conversation_ids_raw) > 0 else None
+        )
 
         result = ConversationService.clear_conversations(
             app_model=app_model, user=current_user, conversation_ids=conversation_ids
@@ -392,10 +396,14 @@ def get(self, app_model):
     def delete(self, app_model):
         current_user, _ = current_account_with_tenant()
         parser = reqparse.RequestParser()
-        parser.add_argument("conversation_ids", type=list, location="json", required=False)
+        parser.add_argument("conversation_ids", type=list, location="json", required=False, default=None)
         args = parser.parse_args()
 
-        conversation_ids = [str(id) for id in args["conversation_ids"]] if args.get("conversation_ids") else None
+        # Convert conversation IDs to strings if provided and non-empty
+        conversation_ids_raw = args.get("conversation_ids")
+        conversation_ids = (
+            [str(id) for id in conversation_ids_raw] if conversation_ids_raw and len(conversation_ids_raw) > 0 else None
+        )
 
         result = ConversationService.clear_conversations(
             app_model=app_model, user=current_user, conversation_ids=conversation_ids
diff --git a/api/tasks/clear_conversation_task.py b/api/tasks/clear_conversation_task.py
@@ -24,7 +24,7 @@
 BATCH_SIZE = 1000
 
 
-@shared_task(bind=True, max_retries=3)
+@shared_task(bind=True, max_retries=3, queue="conversation")
 def clear_conversations_task(
     self,
     app_id: str,
diff --git a/web/app/components/app/log/filter.tsx b/web/app/components/app/log/filter.tsx
@@ -13,7 +13,7 @@ import Sort from '@/app/components/base/sort'
 import Button from '@/app/components/base/button'
 import Confirm from '@/app/components/base/confirm'
 import { useToastContext } from '@/app/components/base/toast'
-import { fetchAnnotationsCount, clearChatConversations, clearCompletionConversations } from '@/service/log'
+import { clearChatConversations, clearCompletionConversations, fetchAnnotationsCount } from '@/service/log'
 dayjs.extend(quarterOfYear)
 
 const today = dayjs()
@@ -50,21 +50,24 @@ const Filter: FC<IFilterProps> = ({ isChatMode, appId, queryParams, setQueryPara
   const handleClearLogs = async (conversationIds?: string[]) => {
     setIsClearing(true)
     try {
-      if (isChatMode) {
+      if (isChatMode)
         await clearChatConversations({ appId, conversationIds })
-      } else {
+      else
         await clearCompletionConversations({ appId, conversationIds })
-      }
-      const message = conversationIds 
-        ? t('appLog.filter.clearSelectedSuccess') 
+
+      const message = conversationIds
+        ? t('appLog.filter.clearSelectedSuccess')
         : t('appLog.filter.clearSuccess')
       notify({ type: 'success', message })
-      onRefresh?.()
+
+      // Wait for onRefresh to complete before clearing selection
+      await onRefresh?.()
       onClearSelected?.(conversationIds)
-    } catch (error) {
-      console.error('Failed to clear logs:', error)
+    }
+    catch {
       notify({ type: 'error', message: t('appLog.filter.clearFailed') })
-    } finally {
+    }
+    finally {
       setIsClearing(false)
       setShowConfirm(false)
     }
@@ -158,8 +161,8 @@ const Filter: FC<IFilterProps> = ({ isChatMode, appId, queryParams, setQueryPara
       {/* Confirmation Dialog */}
       {showConfirm && (
         <Confirm
-          title={showConfirm === 'selected' 
-            ? t('appLog.filter.clearSelectedConfirm.title') 
+          title={showConfirm === 'selected'
+            ? t('appLog.filter.clearSelectedConfirm.title')
             : t('appLog.filter.clearConfirm.title')
           }
           content={showConfirm === 'selected'
diff --git a/web/app/components/base/chat/chat-with-history/hooks.tsx b/web/app/components/base/chat/chat-with-history/hooks.tsx
@@ -198,9 +198,36 @@ export const useChatWithHistory = (installedAppInfo?: InstalledApp) => {
   const { data: appChatListData, isLoading: appChatListDataLoading } = useSWR(
     chatShouldReloadKey ? ['appChatList', chatShouldReloadKey, isInstalledApp, appId] : null,
     () => fetchChatList(chatShouldReloadKey, isInstalledApp, appId),
-    { revalidateOnFocus: false, revalidateOnReconnect: false },
+    {
+      revalidateOnFocus: false,
+      revalidateOnReconnect: false,
+      onError: (error) => {
+        // Handle 404 errors for deleted conversations
+        if ((error?.status === 404 || error?.message?.includes('Conversation Not Exists')) && appId)
+          handleConversationIdInfoChange('')
+      },
+    },
   )
 
+  // Validate if currentConversationId exists in the conversation list
+  // If not found, clear it from localStorage to prevent 404 errors
+  useEffect(() => {
+    if (!currentConversationId || !appConversationData || !appPinnedConversationData)
+      return
+
+    const allConversations = [
+      ...(appPinnedConversationData?.data || []),
+      ...(appConversationData?.data || []),
+    ]
+
+    const conversationExists = allConversations.some(
+      (conv: ConversationItem) => conv.id === currentConversationId,
+    )
+
+    if (!conversationExists)
+      handleConversationIdInfoChange('')
+  }, [currentConversationId, appConversationData, appPinnedConversationData, handleConversationIdInfoChange])
+
   const [clearChatList, setClearChatList] = useState(false)
   const [isResponding, setIsResponding] = useState(false)
   const appPrevChatTree = useMemo(
diff --git a/web/service/fetch.ts b/web/service/fetch.ts
@@ -180,6 +180,12 @@ async function base<T>(url: string, options: FetchOptionType = {}, otherOptions:
     },
   })
 
+  // Ensure body is sent for DELETE requests if provided
+  // ky should handle this, but we ensure it's explicitly set
+  let bodyOptions = {}
+  if (body !== undefined && body !== null)
+    bodyOptions = bodyStringify ? { json: body } : { body: body as BodyInit }
+
   const res = await client(fetchPathname, {
     ...init,
     headers,
@@ -189,7 +195,7 @@ async function base<T>(url: string, options: FetchOptionType = {}, otherOptions:
     retry: {
       methods: [],
     },
-    ...(bodyStringify ? { json: body } : { body: body as BodyInit }),
+    ...bodyOptions,
     searchParams: params,
     fetch(resource: RequestInfo | URL, options?: RequestInit) {
       if (resource instanceof Request && options) {
diff --git a/web/service/log.ts b/web/service/log.ts
@@ -84,30 +84,49 @@ export const fetchAgentLogDetail = ({ appID, params }: { appID: string; params:
 // Clear chat conversations (all or selected)
 export const clearChatConversations = async ({ appId, conversationIds }: { appId: string; conversationIds?: string[] }) => {
   try {
-    const body = conversationIds ? { conversation_ids: conversationIds } : {}
+    const body = conversationIds && conversationIds.length > 0
+      ? { conversation_ids: conversationIds }
+      : { conversation_ids: [] }
+
     const result = await del<any>(`/apps/${appId}/chat-conversations`, { body })
 
-    // Clear localStorage to prevent 404 errors on explore pages
-    // Only clear conversation IDs for this specific app
-    clearConversationIds(appId, { debug: true })
+    // Clear localStorage to prevent 404 errors
+    clearConversationIds(appId)
 
-    // Clear SWR caches
+    // Clear SWR caches to force reload of conversation lists
     await Promise.all([
-      mutate(`/apps/${appId}/chat-conversations`),
-      mutate(`/apps/${appId}/completion-conversations`),
+      // Clear log list caches (key is an object with url and params)
+      // Force cache invalidation with populateCache: false
+      mutate(
+        key =>
+          typeof key === 'object' && key !== null && 'url' in key
+          && (key.url === `/apps/${appId}/chat-conversations` || key.url === `/apps/${appId}/completion-conversations`),
+        undefined,
+        {
+          revalidate: true,
+          populateCache: false,
+        },
+      ),
+      // Clear explore apps caches
       mutate(
         key =>
           typeof key === 'string' && key.includes('/explore/apps'),
         undefined,
         { revalidate: false },
       ),
+      // Clear conversation list caches to trigger validation in useChatWithHistory
+      mutate(
+        key =>
+          Array.isArray(key) && key[0] === 'appConversationData' && key[2] === appId,
+        undefined,
+        { revalidate: true },
+      ),
     ])
 
-    console.log(`✅ Cleared chat conversations for app: ${appId}`)
     return result
   }
   catch (error) {
-    console.error('Failed to clear chat conversations for app:', appId, error)
+    console.error('Failed to clear chat conversations:', error)
     if (error instanceof Error)
       throw new Error(`Failed to clear chat conversations: ${error.message}`)
 
@@ -118,30 +137,49 @@ export const clearChatConversations = async ({ appId, conversationIds }: { appId
 // Clear completion conversations (all or selected)
 export const clearCompletionConversations = async ({ appId, conversationIds }: { appId: string; conversationIds?: string[] }) => {
   try {
-    const body = conversationIds ? { conversation_ids: conversationIds } : {}
+    const body = conversationIds && conversationIds.length > 0
+      ? { conversation_ids: conversationIds }
+      : { conversation_ids: [] }
+
     const result = await del<any>(`/apps/${appId}/completion-conversations`, { body })
 
-    // Clear localStorage to prevent 404 errors on explore pages
-    // Only clear conversation IDs for this specific app
-    clearConversationIds(appId, { debug: true })
+    // Clear localStorage to prevent 404 errors
+    clearConversationIds(appId)
 
-    // Clear SWR caches
+    // Clear SWR caches to force reload of conversation lists
     await Promise.all([
-      mutate(`/apps/${appId}/chat-conversations`),
-      mutate(`/apps/${appId}/completion-conversations`),
+      // Clear log list caches (key is an object with url and params)
+      // Force cache invalidation with populateCache: false
+      mutate(
+        key =>
+          typeof key === 'object' && key !== null && 'url' in key
+          && (key.url === `/apps/${appId}/chat-conversations` || key.url === `/apps/${appId}/completion-conversations`),
+        undefined,
+        {
+          revalidate: true,
+          populateCache: false,
+        },
+      ),
+      // Clear explore apps caches
       mutate(
         key =>
           typeof key === 'string' && key.includes('/explore/apps'),
         undefined,
         { revalidate: false },
       ),
+      // Clear conversation list caches to trigger validation in useChatWithHistory
+      mutate(
+        key =>
+          Array.isArray(key) && key[0] === 'appConversationData' && key[2] === appId,
+        undefined,
+        { revalidate: true },
+      ),
     ])
 
-    console.log(`✅ Cleared completion conversations for app: ${appId}`)
     return result
   }
   catch (error) {
-    console.error('Failed to clear completion conversations for app:', appId, error)
+    console.error('Failed to clear completion conversations:', error)
     if (error instanceof Error)
       throw new Error(`Failed to clear completion conversations: ${error.message}`)
 
