From ee55baf5e2549a6cb0867df54e535cf55deaf277 Mon Sep 17 00:00:00 2001 From: Porthoos <74708619+Porthoos@users.noreply.github.com> Date: Sat, 23 Apr 2022 18:47:40 +0800 Subject: [PATCH 1/3] Update EnglishUnpairedBracketsRuleTest.java add 4 tests for intervals --- .../rules/en/EnglishUnpairedBracketsRuleTest.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java b/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java index 5fc25848694c..363c79297b1d 100644 --- a/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java +++ b/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java @@ -173,6 +173,12 @@ public void testRule() throws IOException { assertCorrect("Some text. This is 12345\", a number."); // could be "inch", so no error assertCorrect("\"When you bring someone,\" he said.\n" + "Gibson introduced the short-scale (30.5\") bass in 1961."); // could be "inch", so no error + + // this test is for intervals which left bracket not matches right bracket, like "[0, 100)" + assertCorrect("The range is [start, end)"); + assertCorrect("The index is in the range (0, 100]"); + assertCorrect("The range should be (number of apples, number of bananas]"); + assertCorrect("The domain of the function is [twenty two, thirty five)"); RuleMatch[] matches; matches = rule.match(Collections.singletonList(lt.getAnalyzedSentence("(This is a test” sentence."))); From 629e909faf37dba38cf997c05a8908eace6b643e Mon Sep 17 00:00:00 2001 From: Porthoos <74708619+Porthoos@users.noreply.github.com> Date: Tue, 24 May 2022 23:40:14 +0800 Subject: [PATCH 2/3] fix issue 6575 add a new rule for detecting sentence end. before fix, languagetool will consider situation " .word." as a webiste url. By adding a case for this, it can be fixed. --- .../main/resources/org/languagetool/resource/segment.srx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/languagetool-core/src/main/resources/org/languagetool/resource/segment.srx b/languagetool-core/src/main/resources/org/languagetool/resource/segment.srx index 7dcd262d4b8b..f1b81c02ca1a 100644 --- a/languagetool-core/src/main/resources/org/languagetool/resource/segment.srx +++ b/languagetool-core/src/main/resources/org/languagetool/resource/segment.srx @@ -1553,6 +1553,12 @@ \b[A-Za-z0-9\-]+\. [A-Za-z0-9\-]+\.(com|net|org|info|de|es|edu|co|eu|nl|io|cn|uk|gov|biz|ca|tk|ru|br|jp|pl)(\.|\b) + + + [.!?] +[A-Za-z0-9\-]+[.!?] + + \b(Drs|Art|Afr|Am|Ar|Br|Cie|Comp|Dhr|([Pp]rof\.)?[Dd]r|Em|Fa|Kon|Bros|Stb)\.\s From 593527e5399bdd73e3250d6089ea03e3c6fd4255 Mon Sep 17 00:00:00 2001 From: Porthoos <74708619+Porthoos@users.noreply.github.com> Date: Wed, 25 May 2022 08:44:00 +0800 Subject: [PATCH 3/3] Update EnglishUnpairedBracketsRuleTest.java delete the unused test cases. --- .../rules/en/EnglishUnpairedBracketsRuleTest.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java b/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java index 363c79297b1d..5fc25848694c 100644 --- a/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java +++ b/languagetool-language-modules/en/src/test/java/org/languagetool/rules/en/EnglishUnpairedBracketsRuleTest.java @@ -173,12 +173,6 @@ public void testRule() throws IOException { assertCorrect("Some text. This is 12345\", a number."); // could be "inch", so no error assertCorrect("\"When you bring someone,\" he said.\n" + "Gibson introduced the short-scale (30.5\") bass in 1961."); // could be "inch", so no error - - // this test is for intervals which left bracket not matches right bracket, like "[0, 100)" - assertCorrect("The range is [start, end)"); - assertCorrect("The index is in the range (0, 100]"); - assertCorrect("The range should be (number of apples, number of bananas]"); - assertCorrect("The domain of the function is [twenty two, thirty five)"); RuleMatch[] matches; matches = rule.match(Collections.singletonList(lt.getAnalyzedSentence("(This is a test” sentence.")));