MorphTo relations are broken in some cases since v11.33.0

[sebj54]

Laravel Version

11.33.0

PHP Version

8.3.13

Database Driver & Version

No response

Description

Since version 11.33.0 and more precisely this commit: 8528d04, the constraints applied on MorphTo relations have changed.

For the example, let's say I have the example relation from the docs: https://laravel.com/docs/11.x/eloquent-relationships#one-to-one-polymorphic-model-structure. So I have an Image model with an imageable relation (MorphTo), pointing to a Post.

Before that commit, the foreign key constraint was correctly added to the relation query: it added a where like this:

[
        "type" => "Basic"
        "column" => "posts.id"
        "operator" => "="
        "value" => 252
        "boolean" => "and"
]

Now with the latest version, the only where is:

[
        "type" => "Null"
        "column" => ""
        "boolean" => "and"
]

This bug breaks some packages like https://github.com/kirschbaum-development/eloquent-power-joins.

Steps To Reproduce

• Create a MorphTo relation (for example Image::imageable)
• Call the relation: $relation = (new Image)->imageable()
• Dump the relation and watch the wheres of the query
• Change your Laravel version from 11.32.x to 11.33.x

Feel free to ask if you need a proper reproduction to work on this but I think you have some test projects already covering this feature.

Thanks for your help!

[crynobone]

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

[sebj54]

Here it is!

https://github.com/sebj54/laravel-morphto-bug

[crynobone]

After reviewing the reproduction code above I wasn't able to replicate the scenario as claimed above:

    public function test_empty_morph_to_relation_has_correct_where(): void
    {
        $relation = (new Image())->imageable();
        $wheres = $relation->getQuery()->getQuery()->wheres;

+       dd($wheres);

        $this->assertContains([
            'type' => 'Null',
            'column' => '',
            'boolean' => 'and',
        ], $wheres);
    }

Before v11.33.0

Current

[sebj54]

Oh right, I see. So there must be a hardcoded check in eloquent-power-joins so.

But what is the point of this constraint? If there is no column for the where clause, why even add it to the query then?

[crynobone]

But what is the point of this constraint? If there is no column for the where clause, why even add it to the query then?

The best bet right now is to assume the current behavior. I can only look further into this if you can provide a "real-world" use case where it was previously a working SQL and now generates an incorrect SQL via Laravel Framework and not 3rd party package.

[sebj54]

Allright then, I'll follow up the issue with the extension developer. Thanks for checking that out!