requestWithoutTrailingSlash on CompiledRouteCollection cause base URL "/" to not work if laravel public folder is linked through api symlink in html folder

[marzoli]

Laravel Version

12.24

PHP Version

8.4.8

Database Driver & Version

PostgreSQL

Description

In the main html folder i have a symbolic link "api" linked to "public" laravel folder. This because in the main html folder i have the compiled angular UI.
I have a route based on the base API URL (apiPrefix = ''): Route::get('/', ...)
If I use route:cache, the Request URL in the CompiledRouteCollection is cleaned of / via requestWithoutTrailingSlash. This causes the API to return: The GET method is not supported for route /.
Without route:cache, it works.

Steps To Reproduce

Steps To Reproduce

Run php artisan route:cache

Open a web browser locally with a URL that includes a subpath, using one of the following methods:

http://localhost/bug-report/public/

or

Create a symlink named api pointing to the public Laravel folder, then open http://localhost/api/ (my case)
The important thing is that there is a subpath in the URL.

I created this repository https://github.com/marzoli/bug-report with your instructions.

I also changed Readme.md with instructions to reproduce

[macropay-solutions]

In laravel 8

Route::get('/', fn (): View => \view('welcome'));

This works after route:cache and the \Illuminate\Routing\CompiledRouteCollection::match function (where requestWithoutTrailingSlash is used) is the same in 8 and 12. Maybe this is not the culprit.

We managed to reproduce it in 12

Update

Now it is not reproducing anymore...

Maybe because we are using the old way of registering the routes in RouteServiceProvider. Can you confirm you are using the same?

[marzoli]

The problem is that my baseURL is www.mydomain.it/api/ where api is a symbolic link pointing to the Laravel public folder (because on parent folder i have UI Angular App).
However, with route:cache, the URL www.mydomain.it/api/ is passed into the trailing function, which removes the final slash (www.mydomain.it/api), and therefore the route doesn't match. What can I do?

My setup is:

$app = Application::configure(basePath: $appBasePath)
    ->withRouting(
        api: __DIR__ . '/../routes/api.php',
        apiPrefix: '',
        commands: __DIR__ . '/../routes/console.php',
        channels: __DIR__ . '/../routes/channels.php',
        health: '/healthcheck',
    )

[macropay-solutions]

We deployed our demo pages also like that in folders but without symbolic links.

https://laravel-news.com/subfolder-install

https://stackoverflow.com/questions/46890085/deploying-laravel-on-a-shared-hosting-sub-directory

You create the subfolder in your public html folder that belongs to your main domain and in it you put .htaccess, index.php and robots.txt from the public folder of laravel.
You edit the index.php code paths to match the real ones like:

if (file_exists($maintenance = __DIR__.'/../../yourFolderOutsideThePublicHtmlFolderForMainDomain/storage/framework/maintenance.php')) {
    require $maintenance;
}

and so on.

The laravel files you put in yourFolderOutsideThePublicHtmlFolderForMainDomain folder.

And then you register the routes like this in the old fashion way (for the new fashion way you have to squeeze your brains out - which we did not).

        $this->routes(function () {
            Route::middleware('api')
                ->prefix('api')
                ->group(base_path('routes/api.php'));
        });

[marzoli]

Okay, I'll change the approach.
I was just saying that with a symbolic link "api" and an empty apiPrefix, the behavior on the "/" route when you do route:cache is different than when there's no cache because the trailing slash is removed only with route:cache.

Thanks.

[macropay-solutions]

You might want to add this important detail in the description of the issue. Also an automated reply will come asking for a public repo in which the issue can be reproduced in case the issue will not be closed directly.

[marzoli]

Ok I change the description.

[marzoli]

The problem can be easily reproduced locally even without symlink using these steps with new laravel project in subfolder:

1. Go to html folder (referred to localhost)
2. composer create-project laravel/laravel example-app
3. Go to link localhost/example-app/public/ -> it works
4. cd example-app
5. php artisan route:cache
6. Go to link localhost/example-app/public/ -> got error

[crynobone]

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

[marzoli]

I created this repository https://github.com/marzoli/bug-report with your instructions.

I also changed Readme.md with instructions to reproduce

[crynobone]

Can you provide a full reproduction code instead of having to follow the instructions? This would eliminate any mistaken configuration when other try to debug the issue.

AS suggested above, Laravel isn't designed to be deployed in subdirectory: https://laravel.com/docs/12.x/installation#directory-configuration

[marzoli]

I can't provide complete reproduction code because I haven't modified any code in the repo I created. The error occurs even with the default Laravel installation, and the only configurations I've made are via WebServer.

On my software prod installation in /var/www/html, I have the files for my UI (Angular) and an "api" symlink pointing to Laravel. It has always worked for 10 years. Since I introduced route:cache, the "GET /" API no longer works. Without it, however, it works because it doesn't do trailing.