chore: Refactor FDv1 behind the datasystem interface #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
keelerm84
force-pushed
the
mk/sdk-1418/retro-fit-fdv1
branch
from
6e3ebf1 to
12bf69b
Compare
jsonbailey
reviewed
Aug 21, 2025
|
|
||
| def stop(self): | ||
| if self._update_processor is not None: | ||
| self._update_processor.stop() |
Contributor
There was a problem hiding this comment.
I don't fully know the logic here, but since we are setting the _update_processor in the start method should we set it back to None after it stops? Would there ever be a case where you could call the start method on a previously stopped processor? It probably doesn't matter in this code since the start method will just overwrite it.
Member
Author
There was a problem hiding this comment.
I don't think it will matter. As you point out, calling start again would override it. But no one is going to be interacting with the datasystem directly. That's all internal to the SDK so shouldn't be an issue.
jsonbailey
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.