Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Commit 0548279

Browse files
LaunchDarklyReleaseBotember-stevensyusintoLaunchDarklyReleaseBotdependabot[bot]
authored
prepare 7.1.8 release (#230)
## [7.1.8] - 2023-08-21 ### Fixed: - In iOS the `defaultValue` argument types for `numberVariation` and `numberVariationDetail` were incorrect so defaultValues were not being passed correctly to the iOS SDK. This affected only iOS the Android counterpart is unaffected. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ember Stevens <[email protected]> Co-authored-by: Ember Stevens <[email protected]> Co-authored-by: Yusinto Ngadiman <[email protected]> Co-authored-by: Yusinto Ngadiman <[email protected]> Co-authored-by: LaunchDarklyReleaseBot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tanderson-ld <[email protected]>
1 parent 5a326dd commit 0548279

File tree

3 files changed

+4297
-4746
lines changed

3 files changed

+4297
-4746
lines changed

ManualTestApp/App.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ const Wrapper = ({ children }: { children: ReactNode }) => {
2020

2121
const Body = () => {
2222
const [client, setClient] = useState<LDClient | null>(null);
23-
const [flagKey, setFlagKey] = useState('dev-test-flag');
24-
const [flagType, setFlagType] = useState('bool');
23+
const [flagKey, setFlagKey] = useState('dev-test-flag1');
24+
const [flagType, setFlagType] = useState('number');
2525
const [isOffline, setIsOffline] = useState(false);
2626
const [contextKey, setContextKey] = useState('context-key');
2727
const [listenerKey, setListenerKey] = useState('');
@@ -83,7 +83,7 @@ const Body = () => {
8383
} else if (flagType === 'string') {
8484
res = await client?.stringVariation(flagKey, '');
8585
} else if (flagType === 'number') {
86-
res = await client?.numberVariation(flagKey, 0.0);
86+
res = await client?.numberVariationDetail(flagKey, 33);
8787
} else if (flagType === 'json') {
8888
res = await client?.jsonVariation(flagKey, null);
8989
}
@@ -137,9 +137,9 @@ const Body = () => {
137137
<View style={styles.row}>
138138
<Button title="Evaluate Flag" onPress={evalFlag} />
139139
<Picker style={{ flex: 1 }} selectedValue={flagType} onValueChange={(itemValue) => setFlagType(itemValue)}>
140+
<Picker.Item label="Number" value="number" />
140141
<Picker.Item label="Bool" value="bool" />
141142
<Picker.Item label="String" value="string" />
142-
<Picker.Item label="Number" value="number" />
143143
<Picker.Item label="JSON" value="json" />
144144
</Picker>
145145
<Text>Offline</Text>

ios/LaunchdarklyReactNativeClientBridge.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ @interface RCT_EXTERN_MODULE(LaunchdarklyReactNativeClient, RCTEventEmitter)
99

1010
RCT_EXTERN_METHOD(boolVariation:(NSString *)flagKey defaultValue:(BOOL *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
1111

12-
RCT_EXTERN_METHOD(numberVariation:(NSString *)flagKey defaultValue:(NSNumber *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
12+
RCT_EXTERN_METHOD(numberVariation:(NSString *)flagKey defaultValue:(double)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
1313

1414
RCT_EXTERN_METHOD(stringVariation:(NSString *)flagKey defaultValue:(NSString *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
1515

1616
RCT_EXTERN_METHOD(jsonVariation:(NSString *)flagKey defaultValue:(id *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
1717

1818
RCT_EXTERN_METHOD(boolVariationDetail:(NSString *)flagKey defaultValue:(BOOL *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
1919

20-
RCT_EXTERN_METHOD(numberVariationDetail:(NSString *)flagKey defaultValue:(NSNumber *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
20+
RCT_EXTERN_METHOD(numberVariationDetail:(NSString *)flagKey defaultValue:(double)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
2121

2222
RCT_EXTERN_METHOD(stringVariationDetail:(NSString *)flagKey defaultValue:(NSString *)defaultValue environment:(NSString *)environment resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
2323

0 commit comments

Comments
 (0)