Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Oct 10, 2025

The latest consul image incorrectly handles a '$' in the key name.
This is causing failing tests since we use an '$inited' key. Until the
consul change is remedied, we need to pin to a working version
of consul.

This is already done in our shared GH action for persistent stores, so I
am updating this SDK to finally use that.


Note

Switches the build workflow to the shared persistent-stores action and makes a minor spec cleanup.

  • CI:
    • Replace inline service containers with launchdarkly/gh-actions/actions/persistent-stores@persistent-stores-v0 in .github/workflows/build-gem.yml.
    • Enable redis, consul, and dynamodb via action inputs.
  • Tests:
    • Simplify array join in spec/ldclient_spec.rb (flags_list.map { |f| f[:key] }.join(", ")).

Written by Cursor Bugbot for commit 93ed988. This will update automatically on new commits. Configure here.

The latest consul image disallowed '$' in the key name. This is causing
failing tests since we use an '$inited' key. Until the consul change is
remedied, we need to pin to a working version of consul.

This is already done in our shared GH action for persistent stores, so I
am updating this SDK to finally use that.
@keelerm84 keelerm84 requested a review from a team as a code owner October 10, 2025 14:48
@keelerm84 keelerm84 merged commit 6308826 into main Oct 10, 2025
9 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1494/gh-action branch October 10, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants