From 8c25b2f8f09bd33d83693b6fcd10a98cc5f9eaac Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Fri, 10 Oct 2025 10:44:47 -0400 Subject: [PATCH 1/2] chore: Use gh-actions/actions/persistent-stores The latest consul image disallowed '$' in the key name. This is causing failing tests since we use an '$inited' key. Until the consul change is remedied, we need to pin to a working version of consul. This is already done in our shared GH action for persistent stores, so I am updating this SDK to finally use that. --- .github/workflows/build-gem.yml | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build-gem.yml b/.github/workflows/build-gem.yml index 7ad3eedc..7e65839c 100644 --- a/.github/workflows/build-gem.yml +++ b/.github/workflows/build-gem.yml @@ -22,23 +22,15 @@ jobs: BUILD_PLATFORM: ${{ startsWith(inputs.version, 'jruby') && 'jruby' || 'ruby' }} FLAKY: ${{ startsWith(inputs.version, 'jruby') && 'true' || 'false' }} - services: - redis: - image: redis - ports: - - 6379:6379 - dynamodb: - image: amazon/dynamodb-local - ports: - - 8000:8000 - consul: - image: hashicorp/consul - ports: - - 8500:8500 - steps: - uses: actions/checkout@v4 + - uses: launchdarkly/gh-actions/actions/persistent-stores@persistent-stores-v0 + with: + redis: true + consul: true + dynamodb: true + - uses: ./.github/actions/setup with: version: ${{ inputs.version }} From 93ed9887c1f77433517f74c55c1ca34f5a1579e1 Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Fri, 10 Oct 2025 10:50:46 -0400 Subject: [PATCH 2/2] rubocop -a --- spec/ldclient_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/ldclient_spec.rb b/spec/ldclient_spec.rb index 88e27ab6..04778116 100644 --- a/spec/ldclient_spec.rb +++ b/spec/ldclient_spec.rb @@ -113,7 +113,7 @@ module LaunchDarkly prereq = flags_map[prereq[:key].to_sym] prereq_index = flags_list.index(prereq) if prereq_index > item_index - all_keys = (flags_list.map { |f| f[:key] }).join(", ") + all_keys = flags_list.map { |f| f[:key] }.join(", ") raise "#{item[:key]} depends on #{prereq[:key]}, but #{item[:key]} was listed first; keys in order are [#{all_keys}]" end end