feat: Add support for user agents and wrapper names. #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Apr 7, 2025
| @@ -0,0 +1,40 @@ | |||
| { | |||
Member
Author
There was a problem hiding this comment.
Added this information to js-core and then did a crawl for just these products.
kinyoklion
commented
Apr 7, 2025
|
|
||
| export const UserAgents: Record<string, UserAgent> = sdkUserAgents; | ||
|
|
||
| export namespace UserAgentHelpers { |
Member
Author
There was a problem hiding this comment.
This is a somewhat strange pattern, but it is what was done in this package already. Probably could just be top level functions.
keelerm84
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes required to add unformation about user agents and wrapper names to the meta repository.
Updated
.sdk_metadata.jsonfile: https://github.com/launchdarkly/js-core/blob/main/.sdk_metadata.jsonFor those unfamiliar with this repo the primary purpose is to crawl SDK repositories, collect meta-data, and then put that meta-data into a usable form (A Go and JavaScript package).
Locally I have updated versions of ALL of the meta files to add to all of the repos. But I want to merge this PR before opening 22 more PRs.