only scan in-viewport data when hovering null values with hover bias

Author: leeoniya

dist/uPlot.cjs.js

@@ -3822,7 +3822,6 @@ function uPlot(opts, data, then) {
 		let prox = hov.prox = fnOrSelf(hov.prox);
 		let bias = hov.bias ??= 0;
 
-		// TODO: only scan between in-view idxs (i0, i1)
 		cursor.dataIdx = (self, seriesIdx, cursorIdx, valAtPosX) => {
 			if (seriesIdx == 0)
 				return cursorIdx;
@@ -3846,15 +3845,15 @@ function uPlot(opts, data, then) {
 
 				if (bias == 0 || bias == -1) {
 					j = cursorIdx;
-					while (nonNullLft == null && j-- > 0) {
+					while (nonNullLft == null && --j >= i0) {
 						if (!skip.has(yValues[j]))
 							nonNullLft = j;
 					}
 				}
 
 				if (bias == 0 || bias == 1) {
 					j = cursorIdx;
-					while (nonNullRgt == null && j++ < yValues.length) {
+					while (nonNullRgt == null && ++j <= i1) {
 						if (!skip.has(yValues[j]))
 							nonNullRgt = j;
 					}

dist/uPlot.esm.js

@@ -3820,7 +3820,6 @@ function uPlot(opts, data, then) {
 		let prox = hov.prox = fnOrSelf(hov.prox);
 		let bias = hov.bias ??= 0;
 
-		// TODO: only scan between in-view idxs (i0, i1)
 		cursor.dataIdx = (self, seriesIdx, cursorIdx, valAtPosX) => {
 			if (seriesIdx == 0)
 				return cursorIdx;
@@ -3844,15 +3843,15 @@ function uPlot(opts, data, then) {
 
 				if (bias == 0 || bias == -1) {
 					j = cursorIdx;
-					while (nonNullLft == null && j-- > 0) {
+					while (nonNullLft == null && --j >= i0) {
 						if (!skip.has(yValues[j]))
 							nonNullLft = j;
 					}
 				}
 
 				if (bias == 0 || bias == 1) {
 					j = cursorIdx;
-					while (nonNullRgt == null && j++ < yValues.length) {
+					while (nonNullRgt == null && ++j <= i1) {
 						if (!skip.has(yValues[j]))
 							nonNullRgt = j;
 					}

dist/uPlot.iife.js

@@ -3823,7 +3823,6 @@ var uPlot = (function () {
 			let prox = hov.prox = fnOrSelf(hov.prox);
 			let bias = hov.bias ??= 0;
 
-			// TODO: only scan between in-view idxs (i0, i1)
 			cursor.dataIdx = (self, seriesIdx, cursorIdx, valAtPosX) => {
 				if (seriesIdx == 0)
 					return cursorIdx;
@@ -3847,15 +3846,15 @@ var uPlot = (function () {
 
 					if (bias == 0 || bias == -1) {
 						j = cursorIdx;
-						while (nonNullLft == null && j-- > 0) {
+						while (nonNullLft == null && --j >= i0) {
 							if (!skip.has(yValues[j]))
 								nonNullLft = j;
 						}
 					}
 
 					if (bias == 0 || bias == 1) {
 						j = cursorIdx;
-						while (nonNullRgt == null && j++ < yValues.length) {
+						while (nonNullRgt == null && ++j <= i1) {
 							if (!skip.has(yValues[j]))
 								nonNullRgt = j;
 						}

dist/uPlot.iife.min.js

@@ -904,7 +904,6 @@ export default function uPlot(opts, data, then) {
 		let prox = hov.prox = fnOrSelf(hov.prox);
 		let bias = hov.bias ??= 0;
 
-		// TODO: only scan between in-view idxs (i0, i1)
 		cursor.dataIdx = (self, seriesIdx, cursorIdx, valAtPosX) => {
 			if (seriesIdx == 0)
 				return cursorIdx;
@@ -928,15 +927,15 @@ export default function uPlot(opts, data, then) {
 
 				if (bias == 0 || bias == -1) {
 					j = cursorIdx;
-					while (nonNullLft == null && j-- > 0) {
+					while (nonNullLft == null && --j >= i0) {
 						if (!skip.has(yValues[j]))
 							nonNullLft = j;
 					}
 				}
 
 				if (bias == 0 || bias == 1) {
 					j = cursorIdx;
-					while (nonNullRgt == null && j++ < yValues.length) {
+					while (nonNullRgt == null && ++j <= i1) {
 						if (!skip.has(yValues[j]))
 							nonNullRgt = j;
 					}