Skip to content

Commit bfd27d5

Browse files
committed
rename --base to --root-image-name
1 parent 77d38b5 commit bfd27d5

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/build_images.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ on:
1010
description: 'The leaf repository to build.'
1111
required: false
1212
default: https://github.com/legendu-net/docker-jupyterhub
13-
base:
14-
description: 'The name of the base/root Docker image in dependency resolving.'
13+
root_image_name:
14+
description: 'The name of the root Docker image in dependency resolving.'
1515
required: false
1616
jobs:
1717
build_docker_images:
@@ -39,7 +39,7 @@ jobs:
3939
run: |
4040
df -lh
4141
docker ps
42-
./build_images.py --branch ${{ github.event.inputs.branch }} --repo ${{ github.event.inputs.repo }} --base ${{ github.event.inputs.base }}
42+
./build_images.py --branch ${{ github.event.inputs.branch }} --repo ${{ github.event.inputs.repo }} --root-image-name ${{ github.event.inputs.root_image_name }}
4343
cat graph.yaml
4444
docker ps
4545
df -lh

.github/workflows/build_images_regular.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Build Docker Images Regularly
3232
run: |
3333
df -lh
34-
./build_images.py --branch "" --repo "" --base ""
34+
./build_images.py --branch "" --repo "" --root-image-name ""
3535
cat graph.yaml
3636
df -lh
3737
- name: Set Environment Variable

build_images.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ def parse_args(args=None, namespace=None) -> Namespace:
5353
help="The leaf repository to build",
5454
)
5555
parser.add_argument(
56-
"--base",
57-
dest="base",
56+
"--root-image-name",
57+
dest="root_image_name",
5858
required=True,
5959
help="The name of the base/root Docker image in dependency resolving.",
6060
)
@@ -68,7 +68,7 @@ def main() -> None:
6868
if args.repo:
6969
if not args.branch:
7070
args.branch = "dev"
71-
branch_urls = {args.branch: {args.repo: args.base}}
71+
branch_urls = {args.branch: {args.repo: args.root_image_name}}
7272
builder = DockerImageBuilder(branch_urls)
7373
builder.build_images(remove=True)
7474
builder.save_graph()

0 commit comments

Comments
 (0)