💥!: Drug is now abstract

Refactored the pharmacy class to remove all the logic from it.
The drugs containing their own logic, they are in charge of updating themselves.

Drug is made abstract because instantiating a drug with its name and expecting the logic to remain does not work anymore. The appropriate class should be used instead.

Author: Coniface

src/index.ts

@@ -1,19 +1,22 @@
 import fs from 'fs';
-import { Drug } from './model/drug/drug';
+import { Doliprane } from './model/drug/doliprane';
+import { Fervex } from './model/drug/fervex';
+import { HerbalTea } from './model/drug/herbalTea';
+import { MagicPill } from './model/drug/magicPill';
 import { Pharmacy } from './model/pharmacy/pharmacy';
 
 const drugs = [
-  new Drug('Doliprane', 20, 30),
-  new Drug('Herbal Tea', 10, 5),
-  new Drug('Fervex', 5, 40),
-  new Drug('Magic Pill', 15, 40),
+  new Doliprane(20, 30),
+  new HerbalTea(10, 5),
+  new Fervex(5, 40),
+  new MagicPill(15, 40),
 ];
-const trial = new Pharmacy(drugs);
+const pharmacy = new Pharmacy(drugs);
 
 const log = [];
 
 for (let elapsedDays = 0; elapsedDays < 30; elapsedDays++) {
-  log.push(JSON.stringify(trial.updateBenefitValue()));
+  log.push(JSON.stringify(pharmacy.updateBenefitValue()));
 }
 
 /* eslint-disable no-console */

src/model/drug/drug.test.ts

@@ -1,11 +1,17 @@
 import { DrugName } from '../../type/DrugName';
 import { Drug } from './drug';
 
+class TestDrug extends Drug {
+  constructor(expiresIn: number, benefit: number) {
+    super(DrugName.TEST, expiresIn, benefit);
+  }
+}
+
 describe('Drug', () => {
   let drug: Drug;
 
   beforeEach(() => {
-    drug = new Drug(DrugName.TEST, 30, 5);
+    drug = new TestDrug(30, 5);
   });
 
   it('should not allow for a negative benefit', () => {

src/model/drug/drug.ts

@@ -1,10 +1,11 @@
-import { DrugName, DrugNameType } from '../../type/DrugName';
+import { boundNumber } from '../../tools/boundNumber';
+import { DrugName } from '../../type/DrugName';
 
-export class Drug {
+export abstract class Drug {
   private _internalBenefit: number;
 
-  constructor(
-    public readonly name: DrugName | DrugNameType,
+  protected constructor(
+    public readonly name: DrugName,
     public expiresIn: number,
     benefit: number
   ) {
@@ -20,7 +21,7 @@ export class Drug {
    * @param value
    */
   public set benefit(value: number) {
-    this._internalBenefit = Math.max(0, value);
+    this._internalBenefit = boundNumber(value, 0, 50);
   }
 
   /**
@@ -33,9 +34,11 @@ export class Drug {
   /**
    * Update internal expiration and benefit values according to drug's rules
    */
-  public updateValues() {
+  public updateValues(): this {
     this.benefit -= this.isExpired() ? 2 : 1;
     this.expiresIn -= 1;
+
+    return this;
   }
 
   /**

src/model/drug/fervex.ts

@@ -17,5 +17,7 @@ export class Fervex extends Drug {
       this.benefit = 0;
     }
     this.expiresIn -= 1;
+
+    return this;
   }
 }

src/model/drug/herbalTea.ts

@@ -13,5 +13,7 @@ export class HerbalTea extends Drug {
       this.benefit += 1;
     }
     this.expiresIn -= 1;
+
+    return this;
   }
 }

src/model/drug/magicPill.ts

@@ -10,6 +10,7 @@ export class MagicPill extends Drug {
     return false;
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-function
-  public updateValues() {}
+  public updateValues() {
+    return this;
+  }
 }

src/model/pharmacy/pharmacy.test.ts

@@ -1,57 +1,9 @@
-export class Pharmacy {
-  constructor(private readonly drugs = []) {}
+import { Drug } from '../drug/drug';
 
-  updateBenefitValue() {
-    for (let i = 0; i < this.drugs.length; i++) {
-      if (
-        this.drugs[i].name != 'Herbal Tea' &&
-        this.drugs[i].name != 'Fervex'
-      ) {
-        if (this.drugs[i].benefit > 0) {
-          if (this.drugs[i].name != 'Magic Pill') {
-            this.drugs[i].benefit = this.drugs[i].benefit - 1;
-          }
-        }
-      } else {
-        if (this.drugs[i].benefit < 50) {
-          this.drugs[i].benefit = this.drugs[i].benefit + 1;
-          if (this.drugs[i].name == 'Fervex') {
-            if (this.drugs[i].expiresIn < 11) {
-              if (this.drugs[i].benefit < 50) {
-                this.drugs[i].benefit = this.drugs[i].benefit + 1;
-              }
-            }
-            if (this.drugs[i].expiresIn < 6) {
-              if (this.drugs[i].benefit < 50) {
-                this.drugs[i].benefit = this.drugs[i].benefit + 1;
-              }
-            }
-          }
-        }
-      }
-      if (this.drugs[i].name != 'Magic Pill') {
-        this.drugs[i].expiresIn = this.drugs[i].expiresIn - 1;
-      }
-      if (this.drugs[i].expiresIn < 0) {
-        if (this.drugs[i].name != 'Herbal Tea') {
-          if (this.drugs[i].name != 'Fervex') {
-            if (this.drugs[i].benefit > 0) {
-              if (this.drugs[i].name != 'Magic Pill') {
-                this.drugs[i].benefit = this.drugs[i].benefit - 1;
-              }
-            }
-          } else {
-            this.drugs[i].benefit =
-              this.drugs[i].benefit - this.drugs[i].benefit;
-          }
-        } else {
-          if (this.drugs[i].benefit < 50) {
-            this.drugs[i].benefit = this.drugs[i].benefit + 1;
-          }
-        }
-      }
-    }
+export class Pharmacy {
+  constructor(private readonly drugs: Drug[] = []) {}
 
-    return this.drugs;
+  public updateBenefitValue() {
+    return this.drugs.map((drug) => drug.updateValues());
   }
 }

src/model/pharmacy/pharmacy.ts

@@ -5,5 +5,3 @@ export enum DrugName {
   MAGIC_PILL = 'Magic Pill',
   TEST = 'test',
 }
-
-export type DrugNameType = `${DrugName}`;