pubsub: remove redundant sends of hello packet

MarcoPolo · MarcoPolo · commit 529902374142 · 2025-08-29T12:46:54.000-07:00
diff --git a/pubsub.go b/pubsub.go
@@ -919,9 +919,8 @@ func (p *PubSub) handlePendingPeers() {
 		}
 
 		rpcQueue := newRpcQueue(p.peerOutboundQueueSize)
-		rpcQueue.Push(p.getHelloPacket(), true)
-		go p.handleNewPeer(p.ctx, pid, rpcQueue)
 		p.peers[pid] = rpcQueue
+		go p.handleNewPeer(p.ctx, pid, rpcQueue)
 	}
 }
 
@@ -966,7 +965,6 @@ func (p *PubSub) handleDeadPeers() {
 			// we respawn the writer as we need to ensure there is a stream active
 			log.Debugf("peer declared dead but still connected; respawning writer: %s", pid)
 			rpcQueue := newRpcQueue(p.peerOutboundQueueSize)
-			rpcQueue.Push(p.getHelloPacket(), true)
 			p.peers[pid] = rpcQueue
 			go p.handleNewPeerWithBackoff(p.ctx, pid, backoffDelay, rpcQueue)
 		}

Original file line number	Diff line number	Diff line change
`@@ -919,9 +919,8 @@ func (p *PubSub) handlePendingPeers() {`
`919`	`919`	`}`
`920`	`920`
`921`	`921`	`rpcQueue := newRpcQueue(p.peerOutboundQueueSize)`
`922`		`- rpcQueue.Push(p.getHelloPacket(), true)`
`923`		`- go p.handleNewPeer(p.ctx, pid, rpcQueue)`
`924`	`922`	`p.peers[pid] = rpcQueue`
	`923`	`+ go p.handleNewPeer(p.ctx, pid, rpcQueue)`
`925`	`924`	`}`
`926`	`925`	`}`
`927`	`926`
`@@ -966,7 +965,6 @@ func (p *PubSub) handleDeadPeers() {`
`966`	`965`	`// we respawn the writer as we need to ensure there is a stream active`
`967`	`966`	`log.Debugf("peer declared dead but still connected; respawning writer: %s", pid)`
`968`	`967`	`rpcQueue := newRpcQueue(p.peerOutboundQueueSize)`
`969`		`- rpcQueue.Push(p.getHelloPacket(), true)`
`970`	`968`	`p.peers[pid] = rpcQueue`
`971`	`969`	`go p.handleNewPeerWithBackoff(p.ctx, pid, backoffDelay, rpcQueue)`
`972`	`970`	`}`