pubsub: remove redundant sends of hello packet

MarcoPolo · MarcoPolo · commit 85fa407689e4 · 2025-09-15T12:36:44.000-07:00
diff --git a/pubsub.go b/pubsub.go
@@ -944,9 +944,8 @@ func (p *PubSub) handlePendingPeers() {
 		}
 
 		rpcQueue := newRpcQueue(p.peerOutboundQueueSize)
-		rpcQueue.Push(p.getHelloPacket(), true)
-		go p.handleNewPeer(p.ctx, pid, rpcQueue)
 		p.peers[pid] = rpcQueue
+		go p.handleNewPeer(p.ctx, pid, rpcQueue)
 	}
 }
 
@@ -991,7 +990,6 @@ func (p *PubSub) handleDeadPeers() {
 			// we respawn the writer as we need to ensure there is a stream active
 			p.logger.Debug("peer declared dead but still connected; respawning writer", "peer", pid)
 			rpcQueue := newRpcQueue(p.peerOutboundQueueSize)
-			rpcQueue.Push(p.getHelloPacket(), true)
 			p.peers[pid] = rpcQueue
 			go p.handleNewPeerWithBackoff(p.ctx, pid, backoffDelay, rpcQueue)
 		}

Original file line number	Diff line number	Diff line change
`@@ -944,9 +944,8 @@ func (p *PubSub) handlePendingPeers() {`
`944`	`944`	`}`
`945`	`945`
`946`	`946`	`rpcQueue := newRpcQueue(p.peerOutboundQueueSize)`
`947`		`- rpcQueue.Push(p.getHelloPacket(), true)`
`948`		`- go p.handleNewPeer(p.ctx, pid, rpcQueue)`
`949`	`947`	`p.peers[pid] = rpcQueue`
	`948`	`+ go p.handleNewPeer(p.ctx, pid, rpcQueue)`
`950`	`949`	`}`
`951`	`950`	`}`
`952`	`951`
`@@ -991,7 +990,6 @@ func (p *PubSub) handleDeadPeers() {`
`991`	`990`	`// we respawn the writer as we need to ensure there is a stream active`
`992`	`991`	`p.logger.Debug("peer declared dead but still connected; respawning writer", "peer", pid)`
`993`	`992`	`rpcQueue := newRpcQueue(p.peerOutboundQueueSize)`
`994`		`- rpcQueue.Push(p.getHelloPacket(), true)`
`995`	`993`	`p.peers[pid] = rpcQueue`
`996`	`994`	`go p.handleNewPeerWithBackoff(p.ctx, pid, backoffDelay, rpcQueue)`
`997`	`995`	`}`