fix: skip problematic ffmpeg metadata on Windows

closes #109

Author: lightpohl

bin/ffmpeg.js

@@ -2,7 +2,7 @@ import dayjs from "dayjs";
 import fs from "fs";
 import { execWithPromise } from "./exec.js";
 import { LOG_LEVELS, logMessage } from "./logger.js";
-import { escapeArgForShell } from "./util.js";
+import { escapeArgForShell, isWin } from "./util.js";
 
 export const runFfmpeg = async ({
   feed,
@@ -52,14 +52,18 @@ export const runFfmpeg = async ({
       artist,
       album_artist: artist,
       title,
-      subtitle,
-      comment,
       disc,
       track,
       "episode-type": episodeType,
       date,
     };
 
+    if (!isWin) {
+      // Due to limited escape options, these metadata fields often break in Windows
+      metaKeysToValues.comment = comment;
+      metaKeysToValues.subtitle = subtitle
+    }
+
     const metadataString = Object.keys(metaKeysToValues)
       .map((key) => {
         if (!metaKeysToValues[key]) {

bin/util.js

@@ -3,7 +3,7 @@ import path from "path";
 import rssParser from "rss-parser";
 import { logErrorAndExit, logMessage } from "./logger.js";
 
-const isWin = process.platform === "win32";
+export const isWin = process.platform === "win32";
 
 export const defaultRssParserConfig = {
   defaultRSS: 2.0,